Changes in uspace/lib/drv/generic/remote_usbhc.c [50b581d:99172baf] in mainline

File:

• uspace/lib/drv/generic/remote_usbhc.c (modified) (20 diffs)

uspace/lib/drv/generic/remote_usbhc.c

@@ -37 +37 @@
 #include <errno.h>
 #include <assert.h>
+#include <macros.h>
 
 #include "usbhc_iface.h"
@@ -165 +166 @@
 {
         if (!exch || !address)
-                return EINVAL;
+                return EBADMEM;
         sysarg_t new_address;
         const int ret = async_req_4_1(exch, DEV_IFACE_ID(USBHC_DEV_IFACE),
@@ -173 +174 @@
         return ret;
 }
-/*----------------------------------------------------------------------------*/
+
 int usbhc_bind_address(async_exch_t *exch, usb_address_t address,
     devman_handle_t handle)
 {
         if (!exch)
-                return EINVAL;
+                return EBADMEM;
         return async_req_3_0(exch, DEV_IFACE_ID(USBHC_DEV_IFACE),
             IPC_M_USBHC_BIND_ADDRESS, address, handle);
 }
-/*----------------------------------------------------------------------------*/
+
 int usbhc_get_handle(async_exch_t *exch, usb_address_t address,
     devman_handle_t *handle)
 {
         if (!exch)
-                return EINVAL;
+                return EBADMEM;
         sysarg_t h;
         const int ret = async_req_2_1(exch, DEV_IFACE_ID(USBHC_DEV_IFACE),
@@ -195 +196 @@
         return ret;
 }
-/*----------------------------------------------------------------------------*/
+
 int usbhc_release_address(async_exch_t *exch, usb_address_t address)
 {
         if (!exch)
-                return EINVAL;
+                return EBADMEM;
         return async_req_2_0(exch, DEV_IFACE_ID(USBHC_DEV_IFACE),
             IPC_M_USBHC_RELEASE_ADDRESS, address);
 }
-/*----------------------------------------------------------------------------*/
+
 int usbhc_register_endpoint(async_exch_t *exch, usb_address_t address,
     usb_endpoint_t endpoint, usb_transfer_type_t type,
@@ -209 +210 @@
 {
         if (!exch)
-                return EINVAL;
+                return EBADMEM;
         const usb_target_t target =
             {{ .address = address, .endpoint = endpoint }};
@@ -220 +221 @@
 #undef _PACK2
 }
-/*----------------------------------------------------------------------------*/
+
 int usbhc_unregister_endpoint(async_exch_t *exch, usb_address_t address,
     usb_endpoint_t endpoint, usb_direction_t direction)
 {
         if (!exch)
-                return EINVAL;
+                return EBADMEM;
         return async_req_4_0(exch, DEV_IFACE_ID(USBHC_DEV_IFACE),
             IPC_M_USBHC_UNREGISTER_ENDPOINT, address, endpoint, direction);
 }
-/*----------------------------------------------------------------------------*/
+
 int usbhc_read(async_exch_t *exch, usb_address_t address,
     usb_endpoint_t endpoint, uint64_t setup, void *data, size_t size,
     size_t *rec_size)
 {
+        if (!exch)
+                return EBADMEM;
+
         if (size == 0 && setup == 0)
                 return EOK;
 
-        if (!exch)
-                return EINVAL;
         const usb_target_t target =
             {{ .address = address, .endpoint = endpoint }};
@@ -284 +286 @@
         return EOK;
 }
-/*----------------------------------------------------------------------------*/
+
 int usbhc_write(async_exch_t *exch, usb_address_t address,
     usb_endpoint_t endpoint, uint64_t setup, const void *data, size_t size)
 {
+        if (!exch)
+                return EBADMEM;
+
         if (size == 0 && setup == 0)
                 return EOK;
 
-        if (!exch)
-                return EINVAL;
         const usb_target_t target =
             {{ .address = address, .endpoint = endpoint }};
@@ -319 +322 @@
         return (int) opening_request_rc;
 }
-/*----------------------------------------------------------------------------*/
+
 
 static void remote_usbhc_request_address(ddf_fun_t *, void *, ipc_callid_t, ipc_call_t *);
@@ -332 +335 @@
 
 /** Remote USB host controller interface operations. */
-static remote_iface_func_ptr_t remote_usbhc_iface_ops[] = {
+static const remote_iface_func_ptr_t remote_usbhc_iface_ops[] = {
         [IPC_M_USBHC_REQUEST_ADDRESS] = remote_usbhc_request_address,
         [IPC_M_USBHC_RELEASE_ADDRESS] = remote_usbhc_release_address,
@@ -347 +350 @@
 /** Remote USB host controller interface structure.
  */
-remote_iface_t remote_usbhc_iface = {
-        .method_count = sizeof(remote_usbhc_iface_ops) /
-            sizeof(remote_usbhc_iface_ops[0]),
+const remote_iface_t remote_usbhc_iface = {
+        .method_count = ARRAY_SIZE(remote_usbhc_iface_ops),
         .methods = remote_usbhc_iface_ops
 };
@@ -361 +363 @@
 static void async_transaction_destroy(async_transaction_t *trans)
 {
-        if (trans == NULL) {
-                return;
-        }
-        if (trans->buffer != NULL) {
+        if (trans == NULL)
+                return;
+        
+        if (trans->buffer != NULL)
                 free(trans->buffer);
-        }
-
+        
         free(trans);
 }
@@ -384 +385 @@
         return trans;
 }
-/*----------------------------------------------------------------------------*/
+
 void remote_usbhc_request_address(ddf_fun_t *fun, void *iface,
     ipc_callid_t callid, ipc_call_t *call)
@@ -406 +407 @@
         }
 }
-/*----------------------------------------------------------------------------*/
+
 void remote_usbhc_bind_address(ddf_fun_t *fun, void *iface,
     ipc_callid_t callid, ipc_call_t *call)
@@ -423 +424 @@
         async_answer_0(callid, ret);
 }
-/*----------------------------------------------------------------------------*/
+
 void remote_usbhc_get_handle(ddf_fun_t *fun, void *iface,
     ipc_callid_t callid, ipc_call_t *call)
@@ -444 +445 @@
         }
 }
-/*----------------------------------------------------------------------------*/
+
 void remote_usbhc_release_address(ddf_fun_t *fun, void *iface,
     ipc_callid_t callid, ipc_call_t *call)
@@ -460 +461 @@
         async_answer_0(callid, ret);
 }
-/*----------------------------------------------------------------------------*/
+
 static void callback_out(ddf_fun_t *fun,
     int outcome, void *arg)
@@ -470 +471 @@
         async_transaction_destroy(trans);
 }
-/*----------------------------------------------------------------------------*/
+
 static void callback_in(ddf_fun_t *fun,
     int outcome, size_t actual_size, void *arg)
@@ -494 +495 @@
         async_transaction_destroy(trans);
 }
-/*----------------------------------------------------------------------------*/
+
 void remote_usbhc_register_endpoint(ddf_fun_t *fun, void *iface,
     ipc_callid_t callid, ipc_call_t *call)
@@ -583 +584 @@
                 async_answer_0(callid, ENOMEM);
                 async_transaction_destroy(trans);
+                return;
         }
 
@@ -594 +596 @@
         }
 }
-/*----------------------------------------------------------------------------*/
+
 void remote_usbhc_write(
     ddf_fun_t *fun, void *iface, ipc_callid_t callid, ipc_call_t *call)