Changeset 99172baf in mainline for uspace/lib/drv/generic/remote_usbhc.c

Timestamp:

2014-05-20T14:36:17Z (11 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a293fef

Parents:

69d25e2

Message:

the error branch should terminate the function (also avoiding use after free of trans)
(detected by Coverity, CID 10449)

File:

• uspace/lib/drv/generic/remote_usbhc.c (modified) (2 diffs)

uspace/lib/drv/generic/remote_usbhc.c

@@ -363 +363 @@
 static void async_transaction_destroy(async_transaction_t *trans)
 {
-        if (trans == NULL) {
-                return;
-        }
-        if (trans->buffer != NULL) {
+        if (trans == NULL)
+                return;
+        
+        if (trans->buffer != NULL)
                 free(trans->buffer);
-        }
-
+        
         free(trans);
 }
@@ -585 +584 @@
                 async_answer_0(callid, ENOMEM);
                 async_transaction_destroy(trans);
+                return;
         }