Changes in uspace/lib/block/libblock.c [96b02eb9:991f645] in mainline

File:

• uspace/lib/block/libblock.c (modified) (21 diffs)

uspace/lib/block/libblock.c

@@ -66 +66 @@
         fibril_mutex_t lock;
         size_t lblock_size;             /**< Logical block size. */
-        unsigned blocks_cluster;        /**< Physical blocks per block_t */
         unsigned block_count;           /**< Total number of blocks. */
         unsigned blocks_cached;         /**< Number of cached blocks. */
@@ -91 +90 @@
 static int get_block_size(int dev_phone, size_t *bsize);
 static int get_num_blocks(int dev_phone, aoff64_t *nblocks);
-static aoff64_t ba_ltop(devcon_t *devcon, aoff64_t lba);
 
 static devcon_t *devcon_search(devmap_handle_t devmap_handle)
@@ -261 +259 @@
 {
         block_t *b = hash_table_get_instance(item, block_t, hash_link);
-        return b->lba == *key;
+        return b->boff == *key;
 }
 
@@ -294 +292 @@
         cache->mode = mode;
 
-        /* Allow 1:1 or small-to-large block size translation */
-        if (cache->lblock_size % devcon->pblock_size != 0)
-                return ENOTSUP;
-
-        cache->blocks_cluster = cache->lblock_size / devcon->pblock_size;
+        /* No block size translation a.t.m. */
+        assert(cache->lblock_size == devcon->pblock_size);
 
         if (!hash_table_create(&cache->block_hash, CACHE_BUCKETS, 1,
@@ -334 +329 @@
                 if (b->dirty) {
                         memcpy(devcon->comm_area, b->data, b->size);
-                        rc = write_blocks(devcon, b->pba, cache->blocks_cluster);
+                        rc = write_blocks(devcon, b->boff, 1);
                         if (rc != EOK)
                                 return rc;
                 }
 
-                unsigned long key = b->lba;
+                unsigned long key = b->boff;
                 hash_table_remove(&cache->block_hash, &key, 1);
                 
@@ -380 +375 @@
  *                              block pointer on success.
  * @param devmap_handle         Device handle of the block device.
- * @param ba                    Block address (logical).
+ * @param boff                  Block offset.
  * @param flags                 If BLOCK_FLAGS_NOREAD is specified, block_get()
  *                              will not read the contents of the block from the
@@ -387 +382 @@
  * @return                      EOK on success or a negative error code.
  */
-int block_get(block_t **block, devmap_handle_t devmap_handle, aoff64_t ba, int flags)
+int block_get(block_t **block, devmap_handle_t devmap_handle, aoff64_t boff, int flags)
 {
         devcon_t *devcon;
@@ -393 +388 @@
         block_t *b;
         link_t *l;
-        unsigned long key = ba;
+        unsigned long key = boff;
         int rc;
         
@@ -470 +465 @@
                                 fibril_mutex_lock(&devcon->comm_area_lock);
                                 memcpy(devcon->comm_area, b->data, b->size);
-                                rc = write_blocks(devcon, b->pba,
-                                    cache->blocks_cluster);
+                                rc = write_blocks(devcon, b->boff, 1);
                                 fibril_mutex_unlock(&devcon->comm_area_lock);
                                 if (rc != EOK) {
@@ -501 +495 @@
                          */
                         list_remove(&b->free_link);
-                        temp_key = b->lba;
+                        temp_key = b->boff;
                         hash_table_remove(&cache->block_hash, &temp_key, 1);
                 }
@@ -508 +502 @@
                 b->devmap_handle = devmap_handle;
                 b->size = cache->lblock_size;
-                b->lba = ba;
-                b->pba = ba_ltop(devcon, b->lba);
+                b->boff = boff;
                 hash_table_insert(&cache->block_hash, &key, &b->hash_link);
 
@@ -526 +519 @@
                          */
                         fibril_mutex_lock(&devcon->comm_area_lock);
-                        rc = read_blocks(devcon, b->pba, cache->blocks_cluster);
+                        rc = read_blocks(devcon, b->boff, 1);
                         memcpy(b->data, devcon->comm_area, cache->lblock_size);
                         fibril_mutex_unlock(&devcon->comm_area_lock);
@@ -587 +580 @@
                 fibril_mutex_lock(&devcon->comm_area_lock);
                 memcpy(devcon->comm_area, block->data, block->size);
-                rc = write_blocks(devcon, block->pba, cache->blocks_cluster);
+                rc = write_blocks(devcon, block->boff, 1);
                 fibril_mutex_unlock(&devcon->comm_area_lock);
                 block->dirty = false;
@@ -621 +614 @@
                          * Take the block out of the cache and free it.
                          */
-                        unsigned long key = block->lba;
+                        unsigned long key = block->boff;
                         hash_table_remove(&cache->block_hash, &key, 1);
                         free(block);
@@ -719 +712 @@
  *
  * @param devmap_handle Device handle of the block device.
- * @param ba            Address of first block (physical).
+ * @param ba            Address of first block.
  * @param cnt           Number of blocks.
  * @param src           Buffer for storing the data.
@@ -747 +740 @@
  *
  * @param devmap_handle Device handle of the block device.
- * @param ba            Address of first block (physical).
+ * @param ba            Address of first block.
  * @param cnt           Number of blocks.
  * @param src           The data to be written.
@@ -823 +816 @@
             UPPER32(ba), cnt);
         if (rc != EOK) {
-                printf("Error %d reading %zu blocks starting at block %" PRIuOFF64
-                    " from device handle %" PRIun "\n", rc, cnt, ba,
+                printf("Error %d reading %d blocks starting at block %" PRIuOFF64
+                    " from device handle %d\n", rc, cnt, ba,
                     devcon->devmap_handle);
 #ifndef NDEBUG
@@ -850 +843 @@
             UPPER32(ba), cnt);
         if (rc != EOK) {
-                printf("Error %d writing %zu blocks starting at block %" PRIuOFF64
-                    " to device handle %" PRIun "\n", rc, cnt, ba, devcon->devmap_handle);
+                printf("Error %d writing %d blocks starting at block %" PRIuOFF64
+                    " to device handle %d\n", rc, cnt, ba, devcon->devmap_handle);
 #ifndef NDEBUG
                 stacktrace_print();
@@ -862 +855 @@
 static int get_block_size(int dev_phone, size_t *bsize)
 {
-        sysarg_t bs;
+        ipcarg_t bs;
         int rc;
 
@@ -875 +868 @@
 static int get_num_blocks(int dev_phone, aoff64_t *nblocks)
 {
-        sysarg_t nb_l, nb_h;
+        ipcarg_t nb_l, nb_h;
         int rc;
 
@@ -886 +879 @@
 }
 
-/** Convert logical block address to physical block address. */
-static aoff64_t ba_ltop(devcon_t *devcon, aoff64_t lba)
-{
-        assert(devcon->cache != NULL);
-        return lba * devcon->cache->blocks_cluster;
-}
-
 /** @}
  */