Changes in uspace/lib/pcut/src/os/windows.c [9eb1ff5:9b20126] in mainline

File:

• uspace/lib/pcut/src/os/windows.c (modified) (11 diffs)

uspace/lib/pcut/src/os/windows.c

@@ -144 +144 @@
  * @param test Test to be run.
  */
-int pcut_run_test_forking(const char *self_path, pcut_item_t *test) {
+void pcut_run_test_forking(const char *self_path, pcut_item_t *test) {
         /* TODO: clean-up if something goes wrong "in the middle" */
         BOOL okay = FALSE;
@@ -173 +173 @@
         if (!okay) {
                 report_func_fail(test, "CreatePipe(/* stdout */)");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
         okay = SetHandleInformation(link_stdout[0], HANDLE_FLAG_INHERIT, 0);
         if (!okay) {
                 report_func_fail(test, "SetHandleInformation(/* stdout */)");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
 
@@ -185 +185 @@
         if (!okay) {
                 report_func_fail(test, "CreatePipe(/* stderr */)");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
         okay = SetHandleInformation(link_stderr[0], HANDLE_FLAG_INHERIT, 0);
         if (!okay) {
                 report_func_fail(test, "SetHandleInformation(/* stderr */)");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
 
@@ -197 +197 @@
         if (!okay) {
                 report_func_fail(test, "CreatePipe(/* stdin */)");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
         okay = SetHandleInformation(link_stdin[1], HANDLE_FLAG_INHERIT, 0);
         if (!okay) {
                 report_func_fail(test, "SetHandleInformation(/* stdin */)");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
 
@@ -224 +224 @@
         if (!okay) {
                 report_func_fail(test, "CreateProcess()");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
 
@@ -236 +236 @@
         if (!okay) {
                 report_func_fail(test, "CloseHandle(/* stdout */)");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
         okay = CloseHandle(link_stderr[1]);
         if (!okay) {
                 report_func_fail(test, "CloseHandle(/* stderr */)");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
         okay = CloseHandle(link_stdin[0]);
         if (!okay) {
                 report_func_fail(test, "CloseHandle(/* stdin */)");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
 
@@ -267 +267 @@
         if (test_output_thread_reader == NULL) {
                 report_func_fail(test, "CreateThread(/* read test stdout */)");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
 
@@ -281 +281 @@
                 if (!okay) {
                         report_func_fail(test, "TerminateProcess(/* PROCESS_INFORMATION.hProcess */)");
-                        return PCUT_ERROR_INTERNAL_FAILURE;
+                        return;
                 }
                 rc = WaitForSingleObject(process_info.hProcess, INFINITE);
@@ -287 +287 @@
         if (rc != WAIT_OBJECT_0) {
                 report_func_fail(test, "WaitForSingleObject(/* PROCESS_INFORMATION.hProcess */)");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
 
@@ -294 +294 @@
         if (!okay) {
                 report_func_fail(test, "GetExitCodeProcess()");
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+                return;
         }
 
         if (rc == 0) {
-                outcome = PCUT_OUTCOME_PASS;
+                outcome = TEST_OUTCOME_PASS;
         } else if ((rc > 0) && (rc < 10) && !timed_out) {
-                outcome = PCUT_OUTCOME_FAIL;
+                outcome = TEST_OUTCOME_FAIL;
         } else {
-                outcome = PCUT_OUTCOME_INTERNAL_ERROR;
+                outcome = TEST_OUTCOME_ERROR;
         }
 
@@ -309 +309 @@
         if (rc != WAIT_OBJECT_0) {
                 report_func_fail(test, "WaitForSingleObject(/* stdout reader thread */)");
-                return PCUT_ERROR_INTERNAL_FAILURE;
+                return;
         }
 
         pcut_report_test_done_unparsed(test, outcome, extra_output_buffer, OUTPUT_BUFFER_SIZE);
-
-        return outcome;
 }