Changes in uspace/srv/devman/devman.c [ebcb05a:9b415c9] in mainline

File:

• uspace/srv/devman/devman.c (modified) (22 diffs)

uspace/srv/devman/devman.c

@@ -148 +148 @@
 
         log_msg(LVL_NOTE, "Driver `%s' was added to the list of available "
-            "drivers.", drv->name);
+            "drivers.\n", drv->name);
 }
 
@@ -238 +238 @@
 bool read_match_ids(const char *conf_path, match_id_list_t *ids)
 {
-        log_msg(LVL_DEBUG, "read_match_ids(conf_path=\"%s\")", conf_path);
+        log_msg(LVL_DEBUG, "read_match_ids(conf_path=\"%s\")\n", conf_path);
         
         bool suc = false;
@@ -248 +248 @@
         fd = open(conf_path, O_RDONLY);
         if (fd < 0) {
-                log_msg(LVL_ERROR, "Unable to open `%s' for reading: %s.",
+                log_msg(LVL_ERROR, "Unable to open `%s' for reading: %s.\n",
                     conf_path, str_error(fd));
                 goto cleanup;
@@ -257 +257 @@
         lseek(fd, 0, SEEK_SET);
         if (len == 0) {
-                log_msg(LVL_ERROR, "Configuration file '%s' is empty.",
+                log_msg(LVL_ERROR, "Configuration file '%s' is empty.\n",
                     conf_path);
                 goto cleanup;
@@ -265 +265 @@
         if (buf == NULL) {
                 log_msg(LVL_ERROR, "Memory allocation failed when parsing file "
-                    "'%s'.", conf_path);
+                    "'%s'.\n", conf_path);
                 goto cleanup;
         }
@@ -271 +271 @@
         ssize_t read_bytes = safe_read(fd, buf, len);
         if (read_bytes <= 0) {
-                log_msg(LVL_ERROR, "Unable to read file '%s'.", conf_path);
+                log_msg(LVL_ERROR, "Unable to read file '%s'.\n", conf_path);
                 goto cleanup;
         }
@@ -309 +309 @@
 bool get_driver_info(const char *base_path, const char *name, driver_t *drv)
 {
-        log_msg(LVL_DEBUG, "get_driver_info(base_path=\"%s\", name=\"%s\")",
+        log_msg(LVL_DEBUG, "get_driver_info(base_path=\"%s\", name=\"%s\")\n",
             base_path, name);
         
@@ -369 +369 @@
 int lookup_available_drivers(driver_list_t *drivers_list, const char *dir_path)
 {
-        log_msg(LVL_DEBUG, "lookup_available_drivers(dir=\"%s\")", dir_path);
+        log_msg(LVL_DEBUG, "lookup_available_drivers(dir=\"%s\")\n", dir_path);
         
         int drv_cnt = 0;
@@ -403 +403 @@
         dev_node_t *dev;
         
-        log_msg(LVL_DEBUG, "create_root_nodes()");
+        log_msg(LVL_DEBUG, "create_root_nodes()\n");
         
         fibril_rwlock_write_lock(&tree->rwlock);
@@ -488 +488 @@
 void attach_driver(dev_node_t *dev, driver_t *drv)
 {
-        log_msg(LVL_DEBUG, "attach_driver(dev=\"%s\",drv=\"%s\")",
+        log_msg(LVL_DEBUG, "attach_driver(dev=\"%s\",drv=\"%s\")\n",
             dev->pfun->pathname, drv->name);
         
@@ -511 +511 @@
         assert(fibril_mutex_is_locked(&drv->driver_mutex));
         
-        log_msg(LVL_DEBUG, "start_driver(drv=\"%s\")", drv->name);
+        log_msg(LVL_DEBUG, "start_driver(drv=\"%s\")\n", drv->name);
         
         rc = task_spawnl(NULL, drv->binary_path, drv->binary_path, NULL);
         if (rc != EOK) {
-                log_msg(LVL_ERROR, "Spawning driver `%s' (%s) failed: %s.",
+                log_msg(LVL_ERROR, "Spawning driver `%s' (%s) failed: %s.\n",
                     drv->name, drv->binary_path, str_error(rc));
                 return false;
@@ -578 +578 @@
         int phone;
 
-        log_msg(LVL_DEBUG, "pass_devices_to_driver(driver=\"%s\")",
+        log_msg(LVL_DEBUG, "pass_devices_to_driver(driver=\"%s\")\n",
             driver->name);
 
@@ -646 +646 @@
          * immediately and possibly started here as well.
          */
-        log_msg(LVL_DEBUG, "Driver `%s' enters running state.", driver->name);
+        log_msg(LVL_DEBUG, "Driver `%s' enters running state.\n", driver->name);
         driver->state = DRIVER_RUNNING;
 
@@ -663 +663 @@
 void initialize_running_driver(driver_t *driver, dev_tree_t *tree)
 {
-        log_msg(LVL_DEBUG, "initialize_running_driver(driver=\"%s\")",
+        log_msg(LVL_DEBUG, "initialize_running_driver(driver=\"%s\")\n",
             driver->name);
         
@@ -754 +754 @@
          * access any structures that would affect driver_t.
          */
-        log_msg(LVL_DEBUG, "add_device(drv=\"%s\", dev=\"%s\")",
+        log_msg(LVL_DEBUG, "add_device(drv=\"%s\", dev=\"%s\")\n",
             drv->name, dev->pfun->name);
         
@@ -816 +816 @@
         driver_t *drv = find_best_match_driver(drivers_list, dev);
         if (drv == NULL) {
-                log_msg(LVL_ERROR, "No driver found for device `%s'.",
+                log_msg(LVL_ERROR, "No driver found for device `%s'.\n",
                     dev->pfun->pathname);
                 return false;
@@ -854 +854 @@
 bool init_device_tree(dev_tree_t *tree, driver_list_t *drivers_list)
 {
-        log_msg(LVL_DEBUG, "init_device_tree()");
+        log_msg(LVL_DEBUG, "init_device_tree()\n");
         
         tree->current_handle = 0;
@@ -1033 +1033 @@
         fun->pathname = (char *) malloc(pathsize);
         if (fun->pathname == NULL) {
-                log_msg(LVL_ERROR, "Failed to allocate device path.");
+                log_msg(LVL_ERROR, "Failed to allocate device path.\n");
                 return false;
         }
@@ -1064 +1064 @@
         assert(fibril_rwlock_is_write_locked(&tree->rwlock));
         
-        log_msg(LVL_DEBUG, "insert_dev_node(dev=%p, pfun=%p [\"%s\"])",
+        log_msg(LVL_DEBUG, "insert_dev_node(dev=%p, pfun=%p [\"%s\"])\n",
             dev, pfun, pfun->pathname);
 
@@ -1173 +1173 @@
 }
 
-/** Find function with a specified name belonging to given device.
- *
- * Device tree rwlock should be held at least for reading.
- *
- * @param dev Device the function belongs to.
- * @param name Function name (not path).
- * @return Function node.
- * @retval NULL No function with given name.
- */
-fun_node_t *find_fun_node_in_device(dev_node_t *dev, const char *name)
-{
-        assert(dev != NULL);
-        assert(name != NULL);
-
-        fun_node_t *fun;
-        link_t *link;
-
-        for (link = dev->functions.next;
-            link != &dev->functions;
-            link = link->next) {
-                fun = list_get_instance(link, fun_node_t, dev_functions);
-
-                if (str_cmp(name, fun->name) == 0)
-                        return fun;
-        }
-
-        return NULL;
-}
-
-/** Find function node by its class name and index. */
-fun_node_t *find_fun_node_by_class(class_list_t *class_list,
-    const char *class_name, const char *dev_name)
-{
-        assert(class_list != NULL);
-        assert(class_name != NULL);
-        assert(dev_name != NULL);
-
-        fibril_rwlock_read_lock(&class_list->rwlock);
-
-        dev_class_t *cl = find_dev_class_no_lock(class_list, class_name);
-        if (cl == NULL) {
-                fibril_rwlock_read_unlock(&class_list->rwlock);
-                return NULL;
-        }
-
-        dev_class_info_t *dev = find_dev_in_class(cl, dev_name);
-        if (dev == NULL) {
-                fibril_rwlock_read_unlock(&class_list->rwlock);
-                return NULL;
-        }
-
-        fun_node_t *fun = dev->fun;
-
-        fibril_rwlock_read_unlock(&class_list->rwlock);
-
-        return fun;
-}
-
-
 /** Find child function node with a specified name.
  *
@@ -1242 +1183 @@
 fun_node_t *find_node_child(fun_node_t *pfun, const char *name)
 {
-        return find_fun_node_in_device(pfun->child, name);
+        fun_node_t *fun;
+        link_t *link;
+        
+        link = pfun->child->functions.next;
+        
+        while (link != &pfun->child->functions) {
+                fun = list_get_instance(link, fun_node_t, dev_functions);
+                
+                if (str_cmp(name, fun->name) == 0)
+                        return fun;
+                
+                link = link->next;
+        }
+        
+        return NULL;
 }
 
@@ -1404 +1359 @@
 }
 
-dev_class_info_t *find_dev_in_class(dev_class_t *dev_class, const char *dev_name)
-{
-        assert(dev_class != NULL);
-        assert(dev_name != NULL);
-
-        link_t *link;
-        for (link = dev_class->devices.next;
-            link != &dev_class->devices;
-            link = link->next) {
-                dev_class_info_t *dev = list_get_instance(link,
-                    dev_class_info_t, link);
-
-                if (str_cmp(dev->dev_name, dev_name) == 0) {
-                        return dev;
-                }
-        }
-
-        return NULL;
-}
-
 void init_class_list(class_list_t *class_list)
 {