Changes in uspace/lib/clui/tinput.c [3e6a98c5:9d58539] in mainline

File:

• uspace/lib/clui/tinput.c (modified) (5 diffs)

uspace/lib/clui/tinput.c

@@ -40 +40 @@
 #include <errno.h>
 #include <assert.h>
-#include <stdbool.h>
+#include <bool.h>
 #include <tinput.h>
 
@@ -104 +104 @@
 static void tinput_display_tail(tinput_t *ti, size_t start, size_t pad)
 {
-        wchar_t *dbuf = malloc((INPUT_MAX_SIZE + 1) * sizeof(wchar_t));
-        if (!dbuf)
-                return; 
+        wchar_t dbuf[INPUT_MAX_SIZE + 1];
         
         size_t sa;
@@ -148 +146 @@
         
         console_flush(ti->console);
-
-        free(dbuf);
 }
 
@@ -599 +595 @@
 {
         unsigned int i;
-        /* Determine the maximum width of the completion in chars */
-        size_t max_width = 0;
+        /* Determine the maximum length of the completion in chars */
+        size_t max_length = 0;
         for (i = 0; i < cnum; i++)
-                max_width = max(max_width, str_width(compl[i]));
-        
-        unsigned int cols = max(1, (ti->con_cols + 1) / (max_width + 1));
-        unsigned int padding = 0;
-        if ((cols * max_width) + (cols - 1) < ti->con_cols) {
-                padding = ti->con_cols - (cols * max_width) - (cols - 1);
-        }
-        unsigned int col_width = max_width + padding / cols;
+                max_length = max(max_length, str_length(compl[i]));
+        
+        unsigned int cols = max(1, (ti->con_cols + 1) / (max_length + 1));
+        unsigned int col_width = ti->con_cols / cols;
         unsigned int rows = cnum / cols + ((cnum % cols) != 0);
         
@@ -615 +607 @@
         
         for (row = 0; row < rows; row++) {
-                unsigned int display_col = 0;
+                bool wlc = false;
                 for (col = 0; col < cols; col++) {
                         size_t compl_idx = col * rows + row;
                         if (compl_idx >= cnum)
                                 break;
-                        if (col) {
+                        if (col)
                                 printf(" ");
-                                display_col++;
+                        printf("%s", compl[compl_idx]);
+                        size_t compl_len = str_length(compl[compl_idx]);
+                        if (col == cols -1) {
+                                wlc = (compl_len == max_length);
                         }
-                        printf("%s", compl[compl_idx]);
-                        size_t compl_width = str_width(compl[compl_idx]);
-                        display_col += compl_width;
-                        if (col < cols - 1) {
-                                for (i = compl_width; i < col_width; i++) {
+                        else {
+                                for (i = compl_len; i < col_width; i++) {
                                         printf(" ");
-                                        display_col++;
                                 }
                         }
                 }
-                if ((display_col % ti->con_cols) > 0)
-                        printf("\n");
-        }
-        fflush(stdout);
+                if (!wlc) printf("\n");
+        }
 }