Changeset 9f4ce50 in mainline

Timestamp:

2019-02-15T13:10:09Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0f6a85ae

Parents:

89e3152

Message:

Fix test of the comparison function in gsort()

Comparison functions may return arbitrary negative or positive
values, not just -1, 0, 1 that gsort() expects.

Found by Matthieu Riolo, thanks!

File:

• uspace/lib/c/generic/gsort.c (modified) (1 diff)

uspace/lib/c/generic/gsort.c

@@ -80 +80 @@
                 if ((i != 0) &&
                     (cmp(INDEX(data, i, elem_size),
-                    INDEX(data, i - 1, elem_size), arg) == -1)) {
+                    INDEX(data, i - 1, elem_size), arg) < 0)) {
                         memcpy(slot, INDEX(data, i, elem_size), elem_size);
                         memcpy(INDEX(data, i, elem_size), INDEX(data, i - 1, elem_size),