Changeset a25d893 in mainline

Timestamp:

2015-04-10T02:48:42Z (10 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

94e46c9

Parents:

2003739

Message:

uhci,ohci: Whitespace and comments

Location:

uspace/drv/bus/usb

Files:

• ohci/hc.c (modified) (3 diffs)
• ohci/main.c (modified) (1 diff)
• uhci/main.c (modified) (1 diff)

uspace/drv/bus/usb/ohci/hc.c

@@ -178 +178 @@
                 usb_log_error("Failed to create OHCI memory structures: %s.\n",
                     str_error(ret));
+                //TODO: We should disable pio access here
                 return ret;
         }
@@ -393 +394 @@
                     ohci_emulation_reg, OHCI_RD(*ohci_emulation_reg));
                 /* Zero everything but A20State */
+                //TODO: should we ack interrupts before doing this?
                 OHCI_CLR(*ohci_emulation_reg, ~0x100);
                 usb_log_debug(
@@ -402 +404 @@
         if (OHCI_RD(instance->registers->control) & C_IR) {
                 usb_log_debug("SMM driver: request ownership change.\n");
+                //TODO: should we ack interrupts before doing this?
                 OHCI_SET(instance->registers->command_status, CS_OCR);
                 /* Hope that SMM actually knows its stuff or we can hang here */

uspace/drv/bus/usb/ohci/main.c

@@ -56 +56 @@
                 return ENOMEM;
 
-        const int ret =  hc_init(instance, res, irq);
+        const int ret = hc_init(instance, res, irq);
         if (ret == EOK)
                 hcd_set_implementation(hcd, instance, ohci_hc_schedule,

uspace/drv/bus/usb/uhci/main.c

@@ -57 +57 @@
                 return ENOMEM;
 
-        const int ret =  hc_init(instance, res, irq);
+        const int ret = hc_init(instance, res, irq);
         if (ret == EOK)
                 hcd_set_implementation(hcd, instance, uhci_hc_schedule, NULL,