Changeset a35b458 in mainline for uspace/drv/nic/ar9271/wmi.c

Timestamp:

2018-03-02T20:10:49Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f1380b7

Parents:

3061bc1

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)

Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:

• uspace/drv/nic/ar9271/wmi.c (modified) (13 diffs)

uspace/drv/nic/ar9271/wmi.c

@@ -53 +53 @@
 {
         uint32_t cmd_value = host2uint32_t_be(reg_offset);
-        
+
         void *resp_buffer =
             malloc(htc_device->ath_device->ctrl_response_length);
-        
+
         errno_t rc = wmi_send_command(htc_device, WMI_REG_READ,
             (uint8_t *) &cmd_value, sizeof(cmd_value), resp_buffer);
-        
+
         if (rc != EOK) {
                 usb_log_error("Failed to read registry value.\n");
                 return rc;
         }
-        
+
         uint32_t *resp_value = (uint32_t *) ((void *) resp_buffer +
             sizeof(htc_frame_header_t) + sizeof(wmi_command_header_t));
-        
+
         *res = uint32_t_be2host(*resp_value);
-        
+
         return rc;
 }
@@ -88 +88 @@
                 host2uint32_t_be(val)
         };
-        
+
         void *resp_buffer =
             malloc(htc_device->ath_device->ctrl_response_length);
-        
+
         errno_t rc = wmi_send_command(htc_device, WMI_REG_WRITE,
             (uint8_t *) &cmd_buffer, sizeof(cmd_buffer), resp_buffer);
-        
+
         free(resp_buffer);
-        
+
         if (rc != EOK) {
                 usb_log_error("Failed to write registry value.\n");
                 return rc;
         }
-        
+
         return rc;
 }
@@ -119 +119 @@
 {
         uint32_t value;
-        
+
         errno_t rc = wmi_reg_read(htc_device, reg_offset, &value);
         if (rc != EOK) {
@@ -126 +126 @@
                 return rc;
         }
-        
+
         value &= ~clear_bit;
         value |= set_bit;
-        
+
         rc = wmi_reg_write(htc_device, reg_offset, value);
         if (rc != EOK) {
@@ -136 +136 @@
                 return rc;
         }
-        
+
         return rc;
 }
@@ -186 +186 @@
         void *resp_buffer =
             malloc(htc_device->ath_device->ctrl_response_length);
-        
+
         /* Convert values to correct endianness. */
         for (size_t i = 0; i < elements; i++) {
@@ -197 +197 @@
                     host2uint32_t_be(buffer_element->value);
         }
-        
+
         errno_t rc = wmi_send_command(htc_device, WMI_REG_WRITE,
             (uint8_t *) buffer, buffer_size, resp_buffer);
-        
+
         free(buffer);
         free(resp_buffer);
-        
+
         if (rc != EOK) {
                 usb_log_error("Failed to write multi registry value.\n");
                 return rc;
         }
-        
+
         return rc;
 }
@@ -230 +230 @@
         size_t buffer_size = header_size + command_length;
         void *buffer = malloc(buffer_size);
-        
+
         if (command_buffer != NULL)
                 memcpy(buffer+header_size, command_buffer, command_length);
-        
+
         /* Set up WMI header */
         wmi_command_header_t *wmi_header = (wmi_command_header_t *)
@@ -240 +240 @@
         wmi_header->sequence_number =
             host2uint16_t_be(++htc_device->sequence_number);
-        
+
         /* Send message. */
         errno_t rc = htc_send_control_message(htc_device, buffer, buffer_size,
@@ -249 +249 @@
                 return rc;
         }
-        
+
         free(buffer);
-        
+
         bool clean_resp_buffer = false;
         size_t response_buffer_size =
@@ -259 +259 @@
                 clean_resp_buffer = true;
         }
-        
+
         /* Read response. */
         /* TODO: Ignoring WMI management RX messages ~ TX statuses etc. */
@@ -272 +272 @@
                         return rc;
                 }
-                
+
                 if (response_buffer_size < sizeof(htc_frame_header_t) +
                     sizeof(wmi_command_header_t)) {
@@ -279 +279 @@
                         return EINVAL;
                 }
-                
+
                 wmi_command_header_t *wmi_hdr = (wmi_command_header_t *)
                     ((void *) response_buffer + sizeof(htc_frame_header_t));
                 cmd_id = uint16_t_be2host(wmi_hdr->command_id);
         } while(cmd_id & WMI_MGMT_CMD_MASK);
-        
+
         if (clean_resp_buffer)
                 free(response_buffer);
-        
-        return rc;
-}
+
+        return rc;
+}