Changeset a35b458 in mainline for uspace/lib/c/generic/ns.c


Ignore:
Timestamp:
2018-03-02T20:10:49Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
f1380b7
Parents:
3061bc1
git-author:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)
git-committer:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)
Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • uspace/lib/c/generic/ns.c

    r3061bc1 ra35b458  
    5050        errno_t retval;
    5151        ipc_call_t answer;
    52        
     52
    5353        async_sess_t *sess = ns_session_get();
    5454        if (sess == NULL)
    5555                return EIO;
    56        
     56
    5757        async_exch_t *exch = async_exchange_begin(sess);
    5858        aid_t req = async_send_1(exch, NS_REGISTER, service, &answer);
    5959        errno_t rc = async_connect_to_me(exch, 0, service, 0);
    60        
     60
    6161        async_exchange_end(exch);
    62        
     62
    6363        if (rc != EOK) {
    6464                async_forget(req);
    6565                return rc;
    6666        }
    67        
     67
    6868        async_wait_for(req, &retval);
    6969        return rc;
    … …  
    7575        if (sess == NULL)
    7676                return NULL;
    77        
     77
    7878        async_exch_t *exch = async_exchange_begin(sess);
    7979        if (exch == NULL)
    8080                return NULL;
    81        
     81
    8282        async_sess_t *csess =
    8383            async_connect_me_to_iface(exch, iface, service, arg3);
    8484        async_exchange_end(exch);
    85        
     85
    8686        if (csess == NULL)
    8787                return NULL;
    88        
     88
    8989        /*
    9090         * FIXME Ugly hack to work around limitation of implementing
    … …  
    9393         */
    9494        async_sess_args_set(csess, iface, arg3, 0);
    95        
     95
    9696        return csess;
    9797}
    … …  
    103103        if (sess == NULL)
    104104                return NULL;
    105        
     105
    106106        async_exch_t *exch = async_exchange_begin(sess);
    107107        async_sess_t *csess =
    108108            async_connect_me_to_blocking_iface(exch, iface, service, arg3);
    109109        async_exchange_end(exch);
    110        
     110
    111111        if (csess == NULL)
    112112                return NULL;
    113        
     113
    114114        /*
    115115         * FIXME Ugly hack to work around limitation of implementing
    … …  
    118118         */
    119119        async_sess_args_set(csess, iface, arg3, 0);
    120        
     120
    121121        return csess;
    122122}
    … …  
    128128        if (sess == NULL)
    129129                return EIO;
    130        
     130
    131131        async_exch_t *exch = async_exchange_begin(sess);
    132132        errno_t rc = async_req_0_0(exch, NS_PING);
    133133        async_exchange_end(exch);
    134        
     134
    135135        return rc;
    136136}
    … …  
    142142        if (sess == NULL)
    143143                return EIO;
    144        
     144
    145145        exch = async_exchange_begin(sess);
    146146        errno_t rc = async_req_2_0(exch, NS_ID_INTRO, LOWER32(id), UPPER32(id));
    147147        async_exchange_end(exch);
    148        
     148
    149149        return rc;
    150150}
    … …  
    153153{
    154154        async_exch_t *exch;
    155        
     155
    156156        if (sess_ns == NULL) {
    157157                exch = async_exchange_begin(session_ns);
    … …  
    161161                        return NULL;
    162162        }
    163        
     163
    164164        return sess_ns;
    165165}
Note: See TracChangeset for help on using the changeset viewer.