Changeset a35b458 in mainline for uspace/lib/drv/generic/remote_usbhid.c

Timestamp:

2018-03-02T20:10:49Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f1380b7

Parents:

3061bc1

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)

Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:

• uspace/lib/drv/generic/remote_usbhid.c (modified) (13 diffs)

uspace/lib/drv/generic/remote_usbhid.c

@@ -67 +67 @@
          */
         IPC_M_USBHID_GET_EVENT,
-        
+
         /** Get the size of the report descriptor from the HID device.
          *
@@ -78 +78 @@
          */
         IPC_M_USBHID_GET_REPORT_DESCRIPTOR_LENGTH,
-        
+
         /** Get the report descriptor from the HID device.
          *
@@ -101 +101 @@
         if (!dev_sess)
                 return EINVAL;
-        
+
         async_exch_t *exch = async_exchange_begin(dev_sess);
-        
+
         sysarg_t len;
         errno_t rc = async_req_1_1(exch, DEV_IFACE_ID(USBHID_DEV_IFACE),
             IPC_M_USBHID_GET_EVENT_LENGTH, &len);
-        
+
         async_exchange_end(exch);
-        
+
         if (rc == EOK) {
                 if (size != NULL)
                         *size = (size_t) len;
         }
-        
+
         return rc;
 }
@@ -137 +137 @@
         if (!dev_sess)
                 return EINVAL;
-        
+
         if (buf == NULL)
                 return ENOMEM;
-        
+
         if (size == 0)
                 return EINVAL;
-        
+
         size_t buffer_size =  size;
         uint8_t *buffer = malloc(buffer_size);
         if (buffer == NULL)
                 return ENOMEM;
-        
+
         async_exch_t *exch = async_exchange_begin(dev_sess);
-        
+
         ipc_call_t opening_request_call;
         aid_t opening_request = async_send_2(exch,
             DEV_IFACE_ID(USBHID_DEV_IFACE), IPC_M_USBHID_GET_EVENT,
             flags, &opening_request_call);
-        
+
         if (opening_request == 0) {
                 async_exchange_end(exch);
@@ -161 +161 @@
                 return ENOMEM;
         }
-        
+
         ipc_call_t data_request_call;
         aid_t data_request = async_data_read(exch, buffer, buffer_size,
             &data_request_call);
-        
+
         async_exchange_end(exch);
-        
+
         if (data_request == 0) {
                 async_forget(opening_request);
@@ -173 +173 @@
                 return ENOMEM;
         }
-        
+
         errno_t data_request_rc;
         errno_t opening_request_rc;
         async_wait_for(data_request, &data_request_rc);
         async_wait_for(opening_request, &opening_request_rc);
-        
+
         if (data_request_rc != EOK) {
                 /* Prefer return code of the opening request. */
@@ -186 +186 @@
                         return (errno_t) data_request_rc;
         }
-        
+
         if (opening_request_rc != EOK)
                 return (errno_t) opening_request_rc;
-        
+
         size_t act_size = IPC_GET_ARG2(data_request_call);
-        
+
         /* Copy the individual items. */
         memcpy(buf, buffer, act_size);
-        
+
         if (actual_size != NULL)
                 *actual_size = act_size;
-        
+
         if (event_nr != NULL)
                 *event_nr = IPC_GET_ARG1(opening_request_call);
-        
+
         return EOK;
 }
@@ -209 +209 @@
         if (!dev_sess)
                 return EINVAL;
-        
+
         async_exch_t *exch = async_exchange_begin(dev_sess);
-        
+
         sysarg_t arg_size;
         errno_t rc = async_req_1_1(exch, DEV_IFACE_ID(USBHID_DEV_IFACE),
             IPC_M_USBHID_GET_REPORT_DESCRIPTOR_LENGTH, &arg_size);
-        
+
         async_exchange_end(exch);
-        
+
         if (rc == EOK) {
                 if (size != NULL)
                         *size = (size_t) arg_size;
         }
-        
+
         return rc;
 }
@@ -231 +231 @@
         if (!dev_sess)
                 return EINVAL;
-        
+
         if (buf == NULL)
                 return ENOMEM;
-        
+
         if (size == 0)
                 return EINVAL;
-        
+
         async_exch_t *exch = async_exchange_begin(dev_sess);
-        
+
         aid_t opening_request = async_send_1(exch,
             DEV_IFACE_ID(USBHID_DEV_IFACE), IPC_M_USBHID_GET_REPORT_DESCRIPTOR,
@@ -247 +247 @@
                 return ENOMEM;
         }
-        
+
         ipc_call_t data_request_call;
         aid_t data_request = async_data_read(exch, buf, size,
             &data_request_call);
-        
+
         async_exchange_end(exch);
-        
+
         if (data_request == 0) {
                 async_forget(opening_request);
                 return ENOMEM;
         }
-        
+
         errno_t data_request_rc;
         errno_t opening_request_rc;
         async_wait_for(data_request, &data_request_rc);
         async_wait_for(opening_request, &opening_request_rc);
-        
+
         if (data_request_rc != EOK) {
                 /* Prefer return code of the opening request. */
@@ -271 +271 @@
                         return (errno_t) data_request_rc;
         }
-        
+
         if (opening_request_rc != EOK)
                 return (errno_t) opening_request_rc;
-        
+
         size_t act_size = IPC_GET_ARG2(data_request_call);
-        
+
         if (actual_size != NULL)
                 *actual_size = act_size;
-        
+
         return EOK;
 }
@@ -312 +312 @@
 {
         printf("remote_usbhid_get_event_length()\n");
-        
+
         usbhid_iface_t *hid_iface = (usbhid_iface_t *) iface;
 
@@ -326 +326 @@
 //      }
         async_answer_1(callid, EOK, len);
-        
+
 //      if (len < 0) {
 //              async_answer_0(callid, len);