Changeset a35b458 in mainline for uspace/lib/usbvirt/src/ipc_hc.c

Timestamp:

2018-03-02T20:10:49Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f1380b7

Parents:

3061bc1

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)

Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:

• uspace/lib/usbvirt/src/ipc_hc.c (modified) (15 diffs)

uspace/lib/usbvirt/src/ipc_hc.c

@@ -61 +61 @@
         if (!sess)
                 return EINVAL;
-        
+
         if ((setup_buffer == NULL) || (setup_buffer_size == 0))
                 return EINVAL;
-        
+
         if ((data_buffer == NULL) || (data_buffer_size == 0))
                 return EINVAL;
-        
+
         async_exch_t *exch = async_exchange_begin(sess);
-        
+
         aid_t opening_request = async_send_0(exch, IPC_M_USBVIRT_CONTROL_READ,
             NULL);
@@ -76 +76 @@
                 return ENOMEM;
         }
-        
+
         errno_t rc = async_data_write_start(exch, setup_buffer,
             setup_buffer_size);
@@ -84 +84 @@
                 return rc;
         }
-        
+
         ipc_call_t data_request_call;
         aid_t data_request = async_data_read(exch, data_buffer,
             data_buffer_size, &data_request_call);
-        
+
         async_exchange_end(exch);
-        
+
         if (data_request == 0) {
                 async_forget(opening_request);
                 return ENOMEM;
         }
-        
+
         errno_t data_request_rc;
         errno_t opening_request_rc;
         async_wait_for(data_request, &data_request_rc);
         async_wait_for(opening_request, &opening_request_rc);
-        
+
         if (data_request_rc != EOK) {
                 /* Prefer the return code of the opening request. */
@@ -108 +108 @@
                         return (errno_t) data_request_rc;
         }
-        
+
         if (opening_request_rc != EOK)
                 return (errno_t) opening_request_rc;
-        
+
         if (data_transferred_size != NULL)
                 *data_transferred_size = IPC_GET_ARG2(data_request_call);
-        
+
         return EOK;
 }
@@ -135 +135 @@
         if (!sess)
                 return EINVAL;
-        
+
         if ((setup_buffer == NULL) || (setup_buffer_size == 0))
                 return EINVAL;
-        
+
         if ((data_buffer_size > 0) && (data_buffer == NULL))
                 return EINVAL;
-        
+
         async_exch_t *exch = async_exchange_begin(sess);
-        
+
         aid_t opening_request = async_send_1(exch, IPC_M_USBVIRT_CONTROL_WRITE,
             data_buffer_size, NULL);
@@ -150 +150 @@
                 return ENOMEM;
         }
-        
+
         errno_t rc = async_data_write_start(exch, setup_buffer,
             setup_buffer_size);
@@ -158 +158 @@
                 return rc;
         }
-        
+
         if (data_buffer_size > 0) {
                 rc = async_data_write_start(exch, data_buffer,
@@ -168 +168 @@
                 }
         }
-        
+
         async_exchange_end(exch);
-        
+
         errno_t opening_request_rc;
         async_wait_for(opening_request, &opening_request_rc);
-        
+
         return (errno_t) opening_request_rc;
 }
@@ -194 +194 @@
         if (!sess)
                 return EINVAL;
-        
+
         usbvirt_hc_to_device_method_t method;
-        
+
         switch (tr_type) {
         case USB_TRANSFER_INTERRUPT:
@@ -207 +207 @@
                 return EINVAL;
         }
-        
+
         if ((ep <= 0) || (ep >= USBVIRT_ENDPOINT_MAX))
                 return EINVAL;
-        
+
         if ((data == NULL) || (data_size == 0))
                 return EINVAL;
-        
+
         async_exch_t *exch = async_exchange_begin(sess);
-        
+
         aid_t opening_request = async_send_2(exch, method, ep, tr_type, NULL);
         if (opening_request == 0) {
@@ -221 +221 @@
                 return ENOMEM;
         }
-        
+
         ipc_call_t data_request_call;
         aid_t data_request = async_data_read(exch, data, data_size,
             &data_request_call);
-        
+
         async_exchange_end(exch);
-        
+
         if (data_request == 0) {
                 async_forget(opening_request);
                 return ENOMEM;
         }
-        
+
         errno_t data_request_rc;
         errno_t opening_request_rc;
         async_wait_for(data_request, &data_request_rc);
         async_wait_for(opening_request, &opening_request_rc);
-        
+
         if (data_request_rc != EOK) {
                 /* Prefer the return code of the opening request. */
@@ -245 +245 @@
                         return (errno_t) data_request_rc;
         }
-        
+
         if (opening_request_rc != EOK)
                 return (errno_t) opening_request_rc;
-        
+
         if (act_size != NULL)
                 *act_size = IPC_GET_ARG2(data_request_call);
-        
+
         return EOK;
 }
@@ -271 +271 @@
         if (!sess)
                 return EINVAL;
-        
+
         usbvirt_hc_to_device_method_t method;
-        
+
         switch (tr_type) {
         case USB_TRANSFER_INTERRUPT:
@@ -284 +284 @@
                 return EINVAL;
         }
-        
+
         if ((ep <= 0) || (ep >= USBVIRT_ENDPOINT_MAX))
                 return EINVAL;
-        
+
         if ((data == NULL) || (data_size == 0))
                 return EINVAL;
-        
+
         async_exch_t *exch = async_exchange_begin(sess);
-        
+
         aid_t opening_request = async_send_1(exch, method, ep, NULL);
         if (opening_request == 0) {
@@ -298 +298 @@
                 return ENOMEM;
         }
-        
+
         errno_t rc = async_data_write_start(exch, data, data_size);
-        
+
         async_exchange_end(exch);
-        
+
         if (rc != EOK) {
                 async_forget(opening_request);
                 return rc;
         }
-        
+
         errno_t opening_request_rc;
         async_wait_for(opening_request, &opening_request_rc);
-        
+
         return (errno_t) opening_request_rc;
 }