Changeset a46e56b in mainline for uspace/drv/intctl/apic/apic.c

Timestamp:

2018-03-22T06:49:35Z (7 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

77f0a1d

Parents:

3e242d2

git-author:

Jakub Jermar <jakub@…> (2018-03-21 23:29:06)

git-committer:

Jakub Jermar <jakub@…> (2018-03-22 06:49:35)

Message:

Prefer handle over ID in naming handle variables

File:

• uspace/drv/intctl/apic/apic.c (modified) (3 diffs)

uspace/drv/intctl/apic/apic.c

@@ -164 +164 @@
  * @param arg   Local argument.
  */
-static void apic_connection(cap_call_handle_t iid, ipc_call_t *icall, void *arg)
-{
-        cap_call_handle_t callid;
+static void apic_connection(cap_call_handle_t icall_handle, ipc_call_t *icall, void *arg)
+{
+        cap_call_handle_t chandle;
         ipc_call_t call;
         apic_t *apic;
@@ -173 +173 @@
          * Answer the first IPC_M_CONNECT_ME_TO call.
          */
-        async_answer_0(iid, EOK);
+        async_answer_0(icall_handle, EOK);
 
         apic = (apic_t *)ddf_dev_data_get(ddf_fun_get_dev((ddf_fun_t *)arg));
 
         while (true) {
-                callid = async_get_call(&call);
+                chandle = async_get_call(&call);
 
                 if (!IPC_GET_IMETHOD(call)) {
                         /* The other side has hung up. */
-                        async_answer_0(callid, EOK);
+                        async_answer_0(chandle, EOK);
                         return;
                 }
@@ -188 +188 @@
                 switch (IPC_GET_IMETHOD(call)) {
                 case IRC_ENABLE_INTERRUPT:
-                        async_answer_0(callid, apic_enable_irq(apic,
+                        async_answer_0(chandle, apic_enable_irq(apic,
                             IPC_GET_ARG1(call)));
                         break;
                 case IRC_DISABLE_INTERRUPT:
                         /* XXX TODO */
-                        async_answer_0(callid, EOK);
+                        async_answer_0(chandle, EOK);
                         break;
                 case IRC_CLEAR_INTERRUPT:
                         /* Noop */
-                        async_answer_0(callid, EOK);
+                        async_answer_0(chandle, EOK);
                         break;
                 default:
-                        async_answer_0(callid, EINVAL);
+                        async_answer_0(chandle, EINVAL);
                         break;
                 }