Changes in uspace/drv/usbhub/usbhub.c [e93e319:a7528a16] in mainline

File:

• uspace/drv/usbhub/usbhub.c (modified) (4 diffs)

uspace/drv/usbhub/usbhub.c

@@ -405 +405 @@
         //if this hub already uses default address, it cannot request it once more
         if(hub->is_default_address_used) return;
-        int opResult = usb_hub_clear_port_feature(&hub->endpoints.control,
-                                port, USB_HUB_FEATURE_C_PORT_CONNECTION);
-        if(opResult != EOK){
-                usb_log_warning("could not clear port-change-connection flag");
-        }
 
         usb_device_request_setup_packet_t request;
+        int opResult;
         usb_log_info("some connection changed");
         assert(hub->endpoints.control.hc_phone);
@@ -435 +431 @@
                 usb_hub_release_default_address(hub);
         }
-        return;
 }
 
@@ -536 +531 @@
 static void usb_hub_removed_device(
     usb_hub_info_t * hub,uint16_t port) {
-
-        int opResult = usb_hub_clear_port_feature(&hub->endpoints.control,
-                                port, USB_HUB_FEATURE_C_PORT_CONNECTION);
-        if(opResult != EOK){
-                usb_log_warning("could not clear port-change-connection flag");
-        }
+                
         /** \TODO remove device from device manager - not yet implemented in
          * devide manager
@@ -621 +611 @@
         //something connected/disconnected
         if (usb_port_connect_change(&status)) {
+                opResult = usb_hub_clear_port_feature(pipe,
+                    port, USB_HUB_FEATURE_C_PORT_CONNECTION);
+                // TODO: check opResult
                 if (usb_port_dev_connected(&status)) {
                         usb_log_info("some connection changed");