Changes in / [b04967a:a82889e] in mainline

Location:

uspace/lib/usb

Files:

• include/usb/classes/hidparser.h (modified) (4 diffs)
• src/hidparser.c (modified) (19 diffs)

uspace/lib/usb/include/usb/classes/hidparser.h

@@ -88 +88 @@
         /** */  
         int depth;      
-        uint8_t report_id;
         
         /** */  
         link_t link;
-
 } usb_hid_report_path_t;
 
@@ -157 +155 @@
         /** */  
         link_t feature;
-        
-        int use_report_id;
-
-        /** */
-        link_t stack;
 } usb_hid_report_parser_t;      
 
@@ -173 +166 @@
          * @param arg Custom argument.
          */
-        void (*keyboard)(const uint8_t *key_codes, size_t count, const uint8_t report_id, void *arg);
+        void (*keyboard)(const uint8_t *key_codes, size_t count, const uint8_t modifiers, void *arg);
 } usb_hid_report_in_callbacks_t;
 
@@ -276 +269 @@
 
 /** */
-int usb_hid_report_path_set_report_id(usb_hid_report_path_t *usage_path, uint8_t report_id);
-
-/** */
 int usb_hid_report_path_append_item(usb_hid_report_path_t *usage_path, int32_t usage_page, int32_t usage);
 

uspace/lib/usb/src/hidparser.c

@@ -64 +64 @@
 int usb_hid_report_reset_local_items();
 void usb_hid_free_report_list(link_t *head);
-usb_hid_report_item_t *usb_hid_report_item_clone(const usb_hid_report_item_t *item);
+
 /*
  * Data translation private functions
@@ -106 +106 @@
     list_initialize(&(parser->feature));
 
-        list_initialize(&(parser->stack));
-
-        parser->use_report_id = 0;
     return EOK;   
 }
@@ -189 +186 @@
                                         tmp_usage_path = NULL;
 
-                                        usb_hid_report_path_set_report_id(report_item->usage_path, report_item->id);    
-                                        if(report_item->id != 0){
-                                                parser->use_report_id = 1;
-                                        }
                                         
                                         switch(tag) {
@@ -222 +215 @@
                                         if(!(new_report_item = malloc(sizeof(usb_hid_report_item_t)))) {
                                                 return ENOMEM;
-                                        }                                       
+                                        }
                                         memcpy(new_report_item,report_item, sizeof(usb_hid_report_item_t));
-                                        link_initialize(&(new_report_item->link));
-                                        
                                         /* reset local items */
                                         new_report_item->usage_minimum = 0;
                                         new_report_item->usage_maximum = 0;
-                                        new_report_item->designator_index = 0;
-                                        new_report_item->designator_minimum = 0;
-                                        new_report_item->designator_maximum = 0;
-                                        new_report_item->string_index = 0;
-                                        new_report_item->string_minimum = 0;
-                                        new_report_item->string_maximum = 0;
-
-                                        /* reset usage from current usage path */
-                                        usb_hid_report_usage_path_t *path = list_get_instance(&usage_path->link, usb_hid_report_usage_path_t, link);
-                                        path->usage = 0;
                                         
+                                        link_initialize(&(new_report_item->link));
                                         report_item = new_report_item;
                                                                                 
@@ -245 +227 @@
                                 case USB_HID_REPORT_TAG_PUSH:
                                         // push current state to stack
-                                        new_report_item = usb_hid_report_item_clone(report_item);
-                                        list_prepend (&parser->stack, &new_report_item->link);
-                                        
+                                        // not yet implemented
                                         break;
                                 case USB_HID_REPORT_TAG_POP:
                                         // restore current state from stack
-                                        if(list_empty (&parser->stack)) {
-                                                return EINVAL;
-                                        }
-                                        
-                                        report_item = list_get_instance(&parser->stack, usb_hid_report_item_t, link);
-                                        list_remove (parser->stack.next);
-                                        
+                                        // not yet implemented                                             
                                         break;
                                         
@@ -673 +647 @@
         }
 
-        parser->use_report_id = 0;
-
         usb_hid_free_report_list(&parser->input);
         usb_hid_free_report_list(&parser->output);
@@ -704 +676 @@
         size_t i=0;
         size_t j=0;
-        uint8_t report_id = 0;
 
         if(parser == NULL) {
@@ -715 +686 @@
         if(!(keys = malloc(sizeof(uint8_t) * key_count))){
                 return ENOMEM;
-        }
-
-        if(parser->use_report_id != 0) {
-                report_id = data[0];
-                usb_hid_report_path_set_report_id(path, report_id);
         }
 
@@ -727 +693 @@
 
                 item = list_get_instance(list_item, usb_hid_report_item_t, link);
-
                 if(!USB_HID_ITEM_FLAG_CONSTANT(item->item_flags) && 
                    (usb_hid_report_compare_usage_path(item->usage_path, path, flags) == EOK)) {
@@ -750 +715 @@
         }
 
-        callbacks->keyboard(keys, key_count, report_id, arg);
+        callbacks->keyboard(keys, key_count, 0, arg);
            
         free(keys);     
@@ -774 +739 @@
         int32_t mask;
         const uint8_t *foo;
-
+        
         // now only common numbers llowed
         if(item->size > 32) {
@@ -793 +758 @@
                 (usb_pow(10,(item->unit_exponent))));
         }
-
         offset = item->offset + (j * item->size);
-        if(item->id != 0) {
-                offset += 8;
-                usb_log_debug("MOVED OFFSET BY 1Byte, REPORT_ID(%d)\n", item->id);
-        }
         
         // FIXME
@@ -982 +942 @@
 
         int only_page;
-
-        if(report_path->report_id != path->report_id) {
-                return 1;
-        }
 
         if(path->depth == 0){
@@ -1082 +1038 @@
         else {
                 path->depth = 0;
-                path->report_id = 0;
                 list_initialize(&path->link);
                 return path;
@@ -1200 +1155 @@
                 return 0;
         }
-
+        
         item = parser->output.next;
         while(&parser->output != item) {
@@ -1240 +1195 @@
         int length;
         int32_t tmp_value;
-        size_t offset_prefix = 0;
         
         if(parser == NULL) {
                 return EINVAL;
-        }
-
-        if(parser->use_report_id != 0) {
-                buffer[0] = path->report_id;
-                offset_prefix = 8;
         }
 
@@ -1269 +1218 @@
 //                              // variable item
                                 value = usb_hid_translate_data_reverse(report_item, data[idx++]);
-                                offset = report_item->offset + (i * report_item->size) + offset_prefix;
+                                offset = report_item->offset + (i * report_item->size);
                                 length = report_item->size;
                         }
@@ -1275 +1224 @@
                                 //bitmap
                                 value += usb_hid_translate_data_reverse(report_item, data[idx++]);
-                                offset = report_item->offset + offset_prefix;
+                                offset = report_item->offset;
                                 length = report_item->size * report_item->count;
                         }
@@ -1374 +1323 @@
 
 
-int usb_hid_report_path_set_report_id(usb_hid_report_path_t *path, uint8_t report_id)
-{
-        if(path == NULL){
-                return EINVAL;
-        }
-
-        path->report_id = report_id;
-        return EOK;
-}
-
-
-usb_hid_report_item_t *usb_hid_report_item_clone(const usb_hid_report_item_t *item)
-{
-        usb_hid_report_item_t *new_report_item;
-        
-        if(!(new_report_item = malloc(sizeof(usb_hid_report_item_t)))) {
-                return NULL;
-        }                                       
-        memcpy(new_report_item,item, sizeof(usb_hid_report_item_t));
-        link_initialize(&(new_report_item->link));
-
-        return new_report_item;
-}
-
 /**
  * @}