Changeset ab855cd in mainline for kernel/generic/src/time/clock.c

Timestamp:

2022-08-15T17:20:56Z (2 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

eda43238

Parents:

61ae4b0

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2022-08-15 17:16:41)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2022-08-15 17:20:56)

Message:

Remove unnecessary loop

File:

• kernel/generic/src/time/clock.c (modified) (2 diffs)

kernel/generic/src/time/clock.c

@@ -138 +138 @@
 {
         size_t missed_clock_ticks = CPU->missed_clock_ticks;
+        CPU->missed_clock_ticks = 0;
+
         CPU->current_clock_tick += missed_clock_ticks + 1;
         uint64_t current_clock_tick = CPU->current_clock_tick;
@@ -150 +152 @@
          *
          */
-        size_t i;
-        for (i = 0; i <= missed_clock_ticks; i++) {
-                /* Update counters and accounting */
-
-                cpu_update_accounting();
+
+        irq_spinlock_lock(&CPU->timeoutlock, false);
+
+        link_t *cur;
+        while ((cur = list_first(&CPU->timeout_active_list)) != NULL) {
+                timeout_t *timeout = list_get_instance(cur, timeout_t, link);
+
+                if (current_clock_tick <= timeout->deadline) {
+                        break;
+                }
+
+                list_remove(cur);
+                timeout_handler_t handler = timeout->handler;
+                void *arg = timeout->arg;
+
+                irq_spinlock_unlock(&CPU->timeoutlock, false);
+
+                handler(arg);
 
                 irq_spinlock_lock(&CPU->timeoutlock, false);
-
-                link_t *cur;
-                while ((cur = list_first(&CPU->timeout_active_list)) != NULL) {
-                        timeout_t *timeout = list_get_instance(cur, timeout_t,
-                            link);
-
-                        if (current_clock_tick <= timeout->deadline) {
-                                break;
-                        }
-
-                        list_remove(cur);
-                        timeout_handler_t handler = timeout->handler;
-                        void *arg = timeout->arg;
-
-                        irq_spinlock_unlock(&CPU->timeoutlock, false);
-
-                        handler(arg);
-
-                        irq_spinlock_lock(&CPU->timeoutlock, false);
-                }
-
-                irq_spinlock_unlock(&CPU->timeoutlock, false);
         }
-        CPU->missed_clock_ticks = 0;
+
+        irq_spinlock_unlock(&CPU->timeoutlock, false);
 
         /*