Changeset ab936440 in mainline for uspace/drv/char/msim-con/msim-con.c

Timestamp:

2019-02-12T20:42:42Z (6 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f31ca47

Parents:

7f7817a9 (diff), 4805495 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

git-author:

Matthieu Riolo <matthieu.riolo@…> (2019-02-12 20:26:18)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-02-12 20:42:42)

Message:

Merge branch 'master' into bdsh_alias

Conflicts:

uspace/app/bdsh/Makefile
uspace/app/bdsh/cmds/modules/modules.h

Ccheck correction and removing header which includes itself

File:

• uspace/drv/char/msim-con/msim-con.c (modified) (6 diffs)

uspace/drv/char/msim-con/msim-con.c

@@ -43 +43 @@
 static void msim_con_connection(ipc_call_t *, void *);
 
-static errno_t msim_con_read(chardev_srv_t *, void *, size_t, size_t *);
+static errno_t msim_con_read(chardev_srv_t *, void *, size_t, size_t *,
+    chardev_flags_t);
 static errno_t msim_con_write(chardev_srv_t *, const void *, size_t, size_t *);
 
@@ -85 +86 @@
         irq_cmd_t *msim_cmds = NULL;
         errno_t rc;
+        bool bound = false;
 
         circ_buf_init(&con->cbuf, con->buf, msim_con_buf_size, 1);
@@ -143 +145 @@
         }
 
-        ddf_fun_add_to_category(fun, "console");
+        bound = true;
+
+        rc = ddf_fun_add_to_category(fun, "console");
+        if (rc != EOK) {
+                ddf_msg(LVL_ERROR, "Error adding function 'a' to category "
+                    "'console'.");
+                goto error;
+        }
 
         return EOK;
@@ -149 +158 @@
         if (CAP_HANDLE_VALID(con->irq_handle))
                 async_irq_unsubscribe(con->irq_handle);
+        if (bound)
+                ddf_fun_unbind(fun);
         if (fun != NULL)
                 ddf_fun_destroy(fun);
@@ -175 +186 @@
 /** Read from msim console device */
 static errno_t msim_con_read(chardev_srv_t *srv, void *buf, size_t size,
-    size_t *nread)
+    size_t *nread, chardev_flags_t flags)
 {
         msim_con_t *con = (msim_con_t *) srv->srvs->sarg;
@@ -184 +195 @@
         fibril_mutex_lock(&con->buf_lock);
 
-        while (circ_buf_nused(&con->cbuf) == 0)
+        while ((flags & chardev_f_nonblock) == 0 &&
+            circ_buf_nused(&con->cbuf) == 0)
                 fibril_condvar_wait(&con->buf_cv, &con->buf_lock);