Changeset ab936440 in mainline for uspace/lib/ext4/src/balloc.c

Timestamp:

2019-02-12T20:42:42Z (6 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f31ca47

Parents:

7f7817a9 (diff), 4805495 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

git-author:

Matthieu Riolo <matthieu.riolo@…> (2019-02-12 20:26:18)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-02-12 20:42:42)

Message:

Merge branch 'master' into bdsh_alias

Conflicts:

uspace/app/bdsh/Makefile
uspace/app/bdsh/cmds/modules/modules.h

Ccheck correction and removing header which includes itself

File:

• uspace/lib/ext4/src/balloc.c (modified) (1 diff)

uspace/lib/ext4/src/balloc.c

@@ -261 +261 @@
                  * is always after the inode table.
                  */
+                return itable + itable_sz;
+        }
+
+        uint32_t flex_group_size = ext4_superblock_get_flex_group_size(sb);
+        if ((bg_ref->index % flex_group_size) == 0) {
+                /* This is the base group */
+                uint32_t i;
+
                 r = itable + itable_sz;
-                return ext4_filesystem_blockaddr2_index_in_group(sb, r);
-        }
-
-        uint64_t bbmap = ext4_block_group_get_block_bitmap(bg_ref->block_group,
-            sb);
-        uint64_t ibmap = ext4_block_group_get_inode_bitmap(bg_ref->block_group,
-            sb);
-
-        r = ext4_filesystem_index_in_group2blockaddr(sb, 0, bg_ref->index);
-        r += ext4_filesystem_bg_get_backup_blocks(bg_ref);
-
-        if (ext4_filesystem_blockaddr2group(sb, bbmap) != bg_ref->index)
-                bbmap = -1; /* Invalid */
-
-        if (ext4_filesystem_blockaddr2group(sb, ibmap) != bg_ref->index)
-                ibmap = -1;
-
-        while (true) {
-                if (r == bbmap || r == ibmap)
-                        r++;
-                else if (r >= itable && r < (itable + itable_sz))
-                        r = itable + itable_sz;
-                else
-                        break;
-        }
-
-        return r;
+
+                uint32_t total_groups = ext4_superblock_get_block_group_count(sb);
+                for (i = bg_ref->index + 1;
+                    i < min(total_groups, bg_ref->index + flex_group_size); ++i) {
+                        r += ext4_filesystem_bg_get_itable_size(sb, i);
+                }
+
+                return r;
+        }
+
+        uint64_t base_addr = ext4_filesystem_index_in_group2blockaddr(sb, 0,
+            bg_ref->index);
+        uint32_t reserved = ext4_filesystem_bg_get_backup_blocks(bg_ref);
+
+        return base_addr + reserved;
 }