Changes in uspace/lib/usb/src/request.c [bc1c6fb:ad4562c2] in mainline

File:

• uspace/lib/usb/src/request.c (modified) (10 diffs)

uspace/lib/usb/src/request.c

@@ -110 +110 @@
   *     (must be in USB endianness).
   * @param data Buffer where to store data accepted during the DATA stage.
-  *     (they will come in USB endianness).
+  *     (they will come in USB endianess).
   * @param data_size Size of the @p data buffer
   *     (in native endianness).
@@ -161 +161 @@
  * the new address.
  *
+ * @see usb_drv_reserve_default_address
+ * @see usb_drv_release_default_address
+ * @see usb_drv_request_address
+ * @see usb_drv_release_address
+ * @see usb_drv_bind_address
+ *
  * @param pipe Control endpoint pipe (session must be already started).
  * @param new_address New USB address to be set (in native endianness).
@@ -195 +201 @@
  * @param[in] pipe Control endpoint pipe (session must be already started).
  * @param[in] request_type Request type (standard/class/vendor).
- * @param[in] recipient Request recipient (device/interface/endpoint).
  * @param[in] descriptor_type Descriptor type (device/configuration/HID/...).
  * @param[in] descriptor_index Descriptor index.
@@ -230 +235 @@
  * @param[in] pipe Control endpoint pipe (session must be already started).
  * @param[in] request_type Request type (standard/class/vendor).
- * @param[in] recipient Request recipient (device/interface/endpoint).
  * @param[in] descriptor_type Descriptor type (device/configuration/HID/...).
  * @param[in] descriptor_index Descriptor index.
@@ -408 +412 @@
 }
 
-/** Retrieve full configuration descriptor, allocate space for it.
- *
- * The function takes care that full configuration descriptor is returned
- * (i.e. the function will fail when less data then descriptor.totalLength
- * is returned).
- *
- * @param[in] pipe Control endpoint pipe (session must be already started).
- * @param[in] index Configuration index.
- * @param[out] descriptor_ptr Where to store pointer to allocated buffer.
- * @param[out] descriptor_size Where to store the size of the descriptor.
- * @return Error code.
- */
-int usb_request_get_full_configuration_descriptor_alloc(
-    usb_endpoint_pipe_t *pipe, int index,
-    void **descriptor_ptr, size_t *descriptor_size)
-{
-        int rc;
-
-        if (descriptor_ptr == NULL) {
-                return EBADMEM;
-        }
-
-        usb_standard_configuration_descriptor_t bare_config;
-        rc = usb_request_get_bare_configuration_descriptor(pipe, index,
-            &bare_config);
-        if (rc != EOK) {
-                return rc;
-        }
-
-        if (bare_config.descriptor_type != USB_DESCTYPE_CONFIGURATION) {
-                return ENOENT;
-        }
-        if (bare_config.total_length < sizeof(bare_config)) {
-                return ELIMIT;
-        }
-
-        void *buffer = malloc(bare_config.total_length);
-        if (buffer == NULL) {
-                return ENOMEM;
-        }
-
-        size_t transferred = 0;
-        rc = usb_request_get_full_configuration_descriptor(pipe, index,
-            buffer, bare_config.total_length, &transferred);
-        if (rc != EOK) {
-                free(buffer);
-                return rc;
-        }
-
-        if (transferred != bare_config.total_length) {
-                free(buffer);
-                return ELIMIT;
-        }
-
-        /* Everything looks okay, copy the pointers. */
-
-        *descriptor_ptr = buffer;
-
-        if (descriptor_size != NULL) {
-                *descriptor_size = bare_config.total_length;
-        }
-
-        return EOK;
-}
-
 /** Set configuration of USB device.
  *
@@ -524 +463 @@
                 return EEMPTY;
         }
-        /* Subtract first 2 bytes (length and descriptor type). */
+        /* Substract first 2 bytes (length and descriptor type). */
         string_descriptor_size -= 2;
 
@@ -544 +483 @@
         size_t i;
         for (i = 0; i < langs_count; i++) {
-                /* Language code from the descriptor is in USB endianness. */
+                /* Language code from the descriptor is in USB endianess. */
                 /* FIXME: is this really correct? */
                 uint16_t lang_code = (string_descriptor[2 + 2 * i + 1] << 8)
@@ -565 +504 @@
  *
  * @param[in] pipe Control endpoint pipe (session must be already started).
- * @param[in] index String index (in native endianness),
- *      first index has number 1 (index from descriptors can be used directly).
- * @param[in] lang String language (in native endianness).
+ * @param[in] index String index (in native endianess).
+ * @param[in] lang String language (in native endianess).
  * @param[out] string_ptr Where to store allocated string in native encoding.
  * @return Error code.
@@ -577 +515 @@
                 return EBADMEM;
         }
-        /*
-         * Index is actually one byte value and zero index is used
-         * to retrieve list of supported languages.
-         */
-        if ((index < 1) || (index > 0xFF)) {
+        /* Index is actually one byte value. */
+        if (index > 0xFF) {
                 return ERANGE;
         }
@@ -609 +544 @@
                 goto leave;
         }
-        /* Subtract first 2 bytes (length and descriptor type). */
+        /* Substract first 2 bytes (length and descriptor type). */
         string_size -= 2;