Changeset ad5f149 in mainline

Timestamp:

2013-12-31T01:21:35Z (11 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

643e7ba

Parents:

639db552

Message:

uhci: Use foreach_safe to iterate through list.

Location:

uspace/drv/bus/usb/uhci

Files:

• hc.c (modified) (1 diff)
• uhci_batch.c (modified) (1 diff)

uspace/drv/bus/usb/uhci/hc.c

@@ -162 +162 @@
                     &instance->transfers_bulk_full, &done);
 
-                while (!list_empty(&done)) {
-                        link_t *item = list_first(&done);
-                        list_remove(item);
+                list_foreach_safe(done, current, next) {
+                        list_remove(current);
                         uhci_transfer_batch_t *batch =
-                            uhci_transfer_batch_from_link(item);
+                            uhci_transfer_batch_from_link(current);
                         uhci_transfer_batch_finish_dispose(batch);
                 }

uspace/drv/bus/usb/uhci/uhci_batch.c

@@ -70 +70 @@
         assert(uhci_batch);
         assert(uhci_batch->usb_batch);
+        assert(!link_in_use(&uhci_batch->link));
         usb_transfer_batch_finish(uhci_batch->usb_batch,
             uhci_transfer_batch_data_buffer(uhci_batch));