Changeset b2010e2 in mainline

Timestamp:

2013-07-05T08:41:17Z (11 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

507c6f3

Parents:

ca4730a5

Message:

Remove further instances of CHEK_RET_RETURN macro.

Location:

uspace/drv/char

Files:

• ps2mouse/main.c (modified) (1 diff)
• xtkbd/main.c (modified) (1 diff)

uspace/drv/char/ps2mouse/main.c

@@ -80 +80 @@
 static int mouse_add(ddf_dev_t *device)
 {
+        int rc;
+
         if (!device)
                 return EINVAL;
 
-#define CHECK_RET_RETURN(ret, message...) \
-if (ret != EOK) { \
-        ddf_msg(LVL_ERROR, message); \
-        return ret; \
-} else (void)0
+        ps2_mouse_t *mouse = ddf_dev_data_alloc(device, sizeof(ps2_mouse_t));
+        if (mouse == NULL) {
+                ddf_msg(LVL_ERROR, "Failed to allocate mouse driver instance.");
+                return ENOMEM;
+        }
 
-        ps2_mouse_t *mouse = ddf_dev_data_alloc(device, sizeof(ps2_mouse_t));
-        int ret = (mouse == NULL) ? ENOMEM : EOK;
-        CHECK_RET_RETURN(ret, "Failed to allocate mouse driver instance.");
-
-        ret = ps2_mouse_init(mouse, device);
-        CHECK_RET_RETURN(ret,
-            "Failed to initialize mouse driver: %s.", str_error(ret));
+        rc = ps2_mouse_init(mouse, device);
+        if (rc != EOK) {
+                ddf_msg(LVL_ERROR, "Failed to initialize mouse driver: %s.",
+                    str_error(rc));
+                return rc;
+        }
 
         ddf_msg(LVL_NOTE, "Controlling '%s' (%" PRIun ").",

uspace/drv/char/xtkbd/main.c

@@ -80 +80 @@
 static int xt_kbd_add(ddf_dev_t *device)
 {
+        int rc;
+
         if (!device)
                 return EINVAL;
 
-#define CHECK_RET_RETURN(ret, message...) \
-if (ret != EOK) { \
-        ddf_msg(LVL_ERROR, message); \
-        return ret; \
-} else (void)0
+        xt_kbd_t *kbd = ddf_dev_data_alloc(device, sizeof(xt_kbd_t));
+        if (kbd == NULL) {
+                ddf_msg(LVL_ERROR, "Failed to allocate XT/KBD driver instance.");
+                return ENOMEM;
+        }
 
-        xt_kbd_t *kbd = ddf_dev_data_alloc(device, sizeof(xt_kbd_t));
-        int ret = (kbd == NULL) ? ENOMEM : EOK;
-        CHECK_RET_RETURN(ret, "Failed to allocate XT/KBD driver instance.");
-
-        ret = xt_kbd_init(kbd, device);
-        CHECK_RET_RETURN(ret,
-            "Failed to initialize XT_KBD driver: %s.", str_error(ret));
+        rc = xt_kbd_init(kbd, device);
+        if (rc != EOK) {
+                ddf_msg(LVL_ERROR, "Failed to initialize XT_KBD driver: %s.",
+                    str_error(rc));
+                return rc;
+        }
 
         ddf_msg(LVL_NOTE, "Controlling '%s' (%" PRIun ").",