Changes in kernel/generic/src/proc/scheduler.c [55b77d9:b4dc35a] in mainline

File:

• kernel/generic/src/proc/scheduler.c (modified) (9 diffs)

kernel/generic/src/proc/scheduler.c

@@ -237 +237 @@
                  * Take the first thread from the queue.
                  */
-                thread_t *thread = list_get_instance(
-                    list_first(&CPU->rq[i].rq), thread_t, rq_link);
+                thread_t *thread =
+                    list_get_instance(CPU->rq[i].rq_head.next, thread_t, rq_link);
                 list_remove(&thread->rq_link);
                 
@@ -273 +273 @@
 static void relink_rq(int start)
 {
-        list_t list;
-        
-        list_initialize(&list);
+        link_t head;
+        
+        list_initialize(&head);
         irq_spinlock_lock(&CPU->lock, false);
         
@@ -284 +284 @@
                         
                         irq_spinlock_lock(&CPU->rq[i + 1].lock, false);
-                        list_concat(&list, &CPU->rq[i + 1].rq);
+                        list_concat(&head, &CPU->rq[i + 1].rq_head);
                         size_t n = CPU->rq[i + 1].n;
                         CPU->rq[i + 1].n = 0;
@@ -292 +292 @@
                         
                         irq_spinlock_lock(&CPU->rq[i].lock, false);
-                        list_concat(&CPU->rq[i].rq, &list);
+                        list_concat(&CPU->rq[i].rq_head, &head);
                         CPU->rq[i].n += n;
                         irq_spinlock_unlock(&CPU->rq[i].lock, false);
@@ -376 +376 @@
         context_save(&CPU->saved_context);
         context_set(&CPU->saved_context, FADDR(scheduler_separated_stack),
-            (uintptr_t) CPU->stack, STACK_SIZE);
+            (uintptr_t) CPU->stack, CPU_STACK_SIZE);
         context_restore(&CPU->saved_context);
         
@@ -586 +586 @@
          * Searching least priority queues on all CPU's first and most priority
          * queues on all CPU's last.
+         *
          */
         size_t acpu;
@@ -616 +617 @@
                         
                         /* Search rq from the back */
-                        link_t *link = cpu->rq[rq].rq.head.prev;
-                        
-                        while (link != &(cpu->rq[rq].rq.head)) {
-                                thread = (thread_t *) list_get_instance(link,
-                                    thread_t, rq_link);
+                        link_t *link = cpu->rq[rq].rq_head.prev;
+                        
+                        while (link != &(cpu->rq[rq].rq_head)) {
+                                thread = (thread_t *) list_get_instance(link, thread_t, rq_link);
                                 
                                 /*
-                                 * Do not steal CPU-wired threads, threads
-                                 * already stolen, threads for which migration
-                                 * was temporarily disabled or threads whose
-                                 * FPU context is still in the CPU.
+                                 * We don't want to steal CPU-wired threads
+                                 * neither threads already stolen. The latter
+                                 * prevents threads from migrating between CPU's
+                                 * without ever being run. We don't want to
+                                 * steal threads whose FPU context is still in
+                                 * CPU.
+                                 *
                                  */
                                 irq_spinlock_lock(&thread->lock, false);
                                 
-                                if (!(thread->flags & THREAD_FLAG_WIRED) &&
-                                    !(thread->flags & THREAD_FLAG_STOLEN) &&
-                                    !thread->nomigrate &&
-                                    !thread->fpu_context_engaged) {
+                                if ((!(thread->flags & (THREAD_FLAG_WIRED | THREAD_FLAG_STOLEN)))
+                                    && (!(thread->fpu_context_engaged))) {
                                         /*
                                          * Remove thread from ready queue.
                                          */
-                                        irq_spinlock_unlock(&thread->lock,
-                                            false);
+                                        irq_spinlock_unlock(&thread->lock, false);
                                         
                                         atomic_dec(&cpu->nrdy);
@@ -660 +660 @@
                                  */
                                 
-                                irq_spinlock_pass(&(cpu->rq[rq].lock),
-                                    &thread->lock);
+                                irq_spinlock_pass(&(cpu->rq[rq].lock), &thread->lock);
                                 
 #ifdef KCPULB_VERBOSE
@@ -740 +739 @@
                         
                         printf("\trq[%u]: ", i);
-                        list_foreach(cpus[cpu].rq[i].rq, cur) {
-                                thread_t *thread = list_get_instance(cur,
-                                    thread_t, rq_link);
+                        link_t *cur;
+                        for (cur = cpus[cpu].rq[i].rq_head.next;
+                            cur != &(cpus[cpu].rq[i].rq_head);
+                            cur = cur->next) {
+                                thread_t *thread = list_get_instance(cur, thread_t, rq_link);
                                 printf("%" PRIu64 "(%s) ", thread->tid,
                                     thread_states[thread->state]);