Changeset b4df8db in mainline

Timestamp:

2013-03-11T19:48:41Z (12 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

623bab8f

Parents:

e4d96e9

Message:

Allow user-specified fibril stack sizes.

• Let the interrupt fibrils in the i8042 task use small stacks.

Location:

uspace

Files:

• drv/char/i8042/main.c (modified) (3 diffs)
• lib/c/generic/async.c (modified) (3 diffs)
• lib/c/generic/fibril.c (modified) (2 diffs)
• lib/c/include/async.h (modified) (1 diff)
• lib/c/include/fibril.h (modified) (1 diff)

uspace/drv/char/i8042/main.c

@@ -36 +36 @@
 
 #include <libarch/inttypes.h>
+#include <libarch/config.h>
 #include <ddf/driver.h>
 #include <device/hw_res_parsed.h>
@@ -42 +43 @@
 #include <ddf/log.h>
 #include <stdio.h>
+#include <async.h>
 #include "i8042.h"
 
@@ -152 +154 @@
         printf("%s: HelenOS PS/2 driver.\n", NAME);
         ddf_log_init(NAME);
+        
+        /*
+         * Alleviate the virtual memory / page table pressure caused by 
+         * interrupt storms when the default large stacks are used.
+         */
+        async_set_interrupt_handler_stack_size(PAGE_SIZE);
+
         return ddf_driver_main(&i8042_driver);
 }

uspace/lib/c/generic/async.c

@@ -350 +350 @@
 static async_client_conn_t client_connection = default_client_connection;
 static async_interrupt_handler_t interrupt_received = default_interrupt_received;
+static size_t interrupt_handler_stksz = (size_t) -1;
 
 /** Setter for client_connection function pointer.
@@ -370 +371 @@
 {
         interrupt_received = intr;
+}
+
+/** Set the stack size for the interrupt handler notification fibrils.
+ *
+ * @param size Stack size. Use -1 to use the system default stack size.
+ */
+void async_set_interrupt_handler_stack_size(size_t size)
+{
+        interrupt_handler_stksz = size;
 }
 
@@ -587 +597 @@
         msg->call = *call;
         
-        fid_t fid = fibril_create(notification_fibril, msg);
+        fid_t fid = fibril_create_generic(notification_fibril, msg,
+            interrupt_handler_stksz);
         if (fid == 0) {
                 free(msg);

uspace/lib/c/generic/fibril.c

@@ -256 +256 @@
  * @param func Implementing function of the new fibril.
  * @param arg Argument to pass to func.
+ * @param stksz Stack size, -1 for the system default stack size.
  *
  * @return 0 on failure or TLS of the new fibril.
  *
  */
-fid_t fibril_create(int (*func)(void *), void *arg)
+fid_t fibril_create_generic(int (*func)(void *), void *arg, size_t stksz)
 {
         fibril_t *fibril;
@@ -268 +269 @@
                 return 0;
         
-        size_t stack_size = stack_size_get();
+        size_t stack_size = (stksz == (size_t) -1) ? stack_size_get() : stksz;
         fibril->stack = as_area_create((void *) -1, stack_size,
             AS_AREA_READ | AS_AREA_WRITE | AS_AREA_CACHEABLE | AS_AREA_GUARD |

uspace/lib/c/include/async.h

@@ -156 +156 @@
 extern void async_set_client_connection(async_client_conn_t);
 extern void async_set_interrupt_received(async_interrupt_handler_t);
+extern void async_set_interrupt_handler_stack_size(size_t);
 
 /*

uspace/lib/c/include/fibril.h

@@ -86 +86 @@
 extern void context_restore(context_t *ctx) __attribute__((noreturn));
 
-extern fid_t fibril_create(int (*func)(void *), void *arg);
+#define fibril_create(func, arg) \
+        fibril_create_generic((func), (arg), (size_t) -1)
+extern fid_t fibril_create_generic(int (*func)(void *), void *arg, size_t);
 extern void fibril_destroy(fid_t fid);
 extern fibril_t *fibril_setup(void);