Changes in / [40240b1:b53e6d9] in mainline

Location:

uspace

Files:

• app/bdsh/cmds/modules/bdd/bdd.c (modified) (6 diffs)
• srv/part/mbr_part/mbr_part.c (modified) (3 diffs)

uspace/app/bdsh/cmds/modules/bdd/bdd.c

@@ -42 +42 @@
 #include <assert.h>
 
-#define BLOCK_SIZE      512
-#define BPR              16
+enum {
+        /* Number of bytes per row */
+        BPR = 16
+};
 
 static const char *cmdname = "bdd";
@@ -67 +69 @@
         unsigned int i, j;
         dev_handle_t handle;
-        block_t *block;
         uint8_t *blk;
         size_t size, bytes, rows;
+        size_t block_size;
         int rc;
-        bn_t boff;
+        bn_t ba;
         uint8_t b;
 
@@ -83 +85 @@
 
         if (argc >= 3)
-                boff = strtol(argv[2], NULL, 0);
+                ba = strtol(argv[2], NULL, 0);
         else
-                boff = 0;
+                ba = 0;
 
         if (argc >= 4)
@@ -94 +96 @@
         rc = devmap_device_get_handle(argv[1], &handle, 0);
         if (rc != EOK) {
-                printf("Error: could not resolve device `%s'.\n", argv[1]);
+                printf("%s: Error resolving device `%s'.\n", cmdname, argv[1]);
                 return CMD_FAILURE;
         }
 
-        rc = block_init(handle, BLOCK_SIZE);
+        rc = block_init(handle, 2048);
         if (rc != EOK)  {
-                printf("Error: could not init libblock.\n");
+                printf("%s: Error initializing libblock.\n", cmdname);
                 return CMD_FAILURE;
         }
 
-        rc = block_cache_init(handle, BLOCK_SIZE, 2, CACHE_MODE_WB);
+        rc = block_get_bsize(handle, &block_size);
         if (rc != EOK) {
-                printf("Error: could not init block cache.\n");
+                printf("%s: Error determining device block size.\n", cmdname);
+                return CMD_FAILURE;
+        }
+
+        blk = malloc(block_size);
+        if (blk == NULL) {
+                printf("%s: Error allocating memory.\n", cmdname);
+                block_fini(handle);
                 return CMD_FAILURE;
         }
 
         while (size > 0) {
-                rc = block_get(&block, handle, boff, 0);
+                rc = block_read_direct(handle, ba, 1, blk);
                 if (rc != EOK) {
-                        printf("Error: could not get block %u, device %u.\n",
-                            boff, handle);
+                        printf("%s: Error reading block %llu\n", cmdname, ba);
+                        free(blk);
+                        block_fini(handle);
                         return CMD_FAILURE;
                 }
-                blk = (uint8_t *) block->data;
 
-                bytes = (size < BLOCK_SIZE) ? size : BLOCK_SIZE;
+                bytes = (size < block_size) ? size : block_size;
                 rows = (bytes + BPR - 1) / BPR;
 
@@ -145 +154 @@
                 }
 
-                rc = block_put(block);
-                if (rc != EOK) {
-                        printf("Error: could not put block %p.\n",
-                            block);
-                        return CMD_FAILURE;
-                }
-
                 if (size > rows * BPR)
                         size -= rows * BPR;
@@ -157 +159 @@
                         size = 0;
 
-                boff += rows * BPR;
+                /* Next block */
+                ba += 1;
         }
 
+        free(blk);
         block_fini(handle);
 

uspace/srv/part/mbr_part/mbr_part.c

@@ -39 +39 @@
  *
  * Limitations:
- *
+ * 
  * Only works with boot records using LBA. CHS-only records are not
- * supported. Maximum number of partitions is fixed.
+ * supported.
+ *
+ * Referemces:
+ *      
+ * The source of MBR structures for this driver have been the following
+ * Wikipedia articles:
+ *      - http://en.wikipedia.org/wiki/Master_Boot_Record
+ *      - http://en.wikipedia.org/wiki/Extended_boot_record
+ *
+ * The fact that the extended partition has type 0x05 is pure observation.
+ * (TODO: can it have any other type number?)
  */
 
@@ -70 +80 @@
 
         /** Boot record signature */
-        BR_SIGNATURE    = 0xAA55,
+        BR_SIGNATURE    = 0xAA55
 };
 
 enum ptype {
+        /** Unused partition entry */
+        PT_UNUSED       = 0x00,
         /** Extended partition */
-        PT_EXTENDED     = 0x05
+        PT_EXTENDED     = 0x05,
 };
 
@@ -365 +377 @@
         part->length     = len;
 
-        part->present = (sa != 0 || len != 0) ? true : false;
+        part->present = (pte->ptype != PT_UNUSED) ? true : false;
+
         part->dev = 0;
         part->next = NULL;