Changeset b7fd2a0 in mainline for kernel/generic/include/ipc/sysipc_ops.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• kernel/generic/include/ipc/sysipc_ops.h (modified) (5 diffs)

kernel/generic/include/ipc/sysipc_ops.h

@@ -90 +90 @@
          * Invoked on:          all calls
          */
-        int (* request_preprocess)(call_t *, phone_t *);
+        errno_t (* request_preprocess)(call_t *, phone_t *);
 
         /**
@@ -102 +102 @@
          * Invoked on:          all forgotten calls
          */     
-        int (* request_forget)(call_t *);
+        errno_t (* request_forget)(call_t *);
 
         /**
@@ -123 +123 @@
          * Invoked on:          all forgotten calls
          */
-        int (* answer_cleanup)(call_t *, ipc_data_t *);
+        errno_t (* answer_cleanup)(call_t *, ipc_data_t *);
 
         /**
@@ -134 +134 @@
          * Invoked on:          all answered calls
          */
-        int (* answer_preprocess)(call_t *, ipc_data_t *);
+        errno_t (* answer_preprocess)(call_t *, ipc_data_t *);
 
         /**
@@ -144 +144 @@
          * Invoked on:          all answered calls
          */
-        int (* answer_process)(call_t *);
+        errno_t (* answer_process)(call_t *);
 } sysipc_ops_t;
 
 extern sysipc_ops_t *sysipc_ops_get(sysarg_t);
 
-extern int null_request_preprocess(call_t *, phone_t *);
-extern int null_request_forget(call_t *);
+extern errno_t null_request_preprocess(call_t *, phone_t *);
+extern errno_t null_request_forget(call_t *);
 extern int null_request_process(call_t *, answerbox_t *);
-extern int null_answer_cleanup(call_t *, ipc_data_t *);
-extern int null_answer_preprocess(call_t *, ipc_data_t *);
-extern int null_answer_process(call_t *);
+extern errno_t null_answer_cleanup(call_t *, ipc_data_t *);
+extern errno_t null_answer_preprocess(call_t *, ipc_data_t *);
+extern errno_t null_answer_process(call_t *);
 
 #endif