Changeset b7fd2a0 in mainline for kernel/generic/src/ipc/ipc.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• kernel/generic/src/ipc/ipc.c (modified) (7 diffs)

kernel/generic/src/ipc/ipc.c

@@ -208 +208 @@
  *
  */
-int ipc_call_sync(phone_t *phone, call_t *request)
+errno_t ipc_call_sync(phone_t *phone, call_t *request)
 {
         answerbox_t *mybox = slab_alloc(answerbox_cache, 0);
@@ -216 +216 @@
         request->callerbox = mybox;
         
-        int rc = ipc_call(phone, request);
+        errno_t rc = ipc_call(phone, request);
         if (rc != EOK) {
                 slab_free(answerbox_cache, mybox);
@@ -371 +371 @@
  *
  */
-void ipc_backsend_err(phone_t *phone, call_t *call, int err)
+void ipc_backsend_err(phone_t *phone, call_t *call, errno_t err)
 {
         _ipc_call_actions_internal(phone, call, false);
@@ -415 +415 @@
  *
  */
-int ipc_call(phone_t *phone, call_t *call)
+errno_t ipc_call(phone_t *phone, call_t *call)
 {
         mutex_lock(&phone->lock);
@@ -448 +448 @@
  *
  */
-int ipc_phone_hangup(phone_t *phone)
+errno_t ipc_phone_hangup(phone_t *phone)
 {
         mutex_lock(&phone->lock);
@@ -495 +495 @@
  *
  */
-int ipc_forward(call_t *call, phone_t *newphone, answerbox_t *oldbox,
+errno_t ipc_forward(call_t *call, phone_t *newphone, answerbox_t *oldbox,
     unsigned int mode)
 {
@@ -535 +535 @@
         uint64_t answer_cnt = 0;
         uint64_t call_cnt = 0;
-        int rc;
+        errno_t rc;
         
 restart: