Changes in kernel/generic/src/ipc/kbox.c [48bcf49:b7fd2a0] in mainline

File:

• kernel/generic/src/ipc/kbox.c (modified) (3 diffs)

kernel/generic/src/ipc/kbox.c

@@ -206 +206 @@
  * cleanup code.
  *
- * @return Phone capability handle on success, or negative error code.
- *
- */
-int ipc_connect_kbox(task_id_t taskid)
+ * @param[out] out_phone  Phone capability handle on success.
+ * @return Error code.
+ *
+ */
+errno_t ipc_connect_kbox(task_id_t taskid, cap_handle_t *out_phone)
 {
         irq_spinlock_lock(&tasks_lock, true);
@@ -231 +232 @@
         }
         
-        if (task->kb.finished != false) {
+        if (task->kb.finished) {
                 mutex_unlock(&task->kb.cleanup_lock);
                 return EINVAL;
         }
         
-        cap_handle_t phone_handle = phone_alloc(TASK);
-        if (phone_handle < 0) {
+        /* Create a kbox thread if necessary. */
+        if (task->kb.thread == NULL) {
+                thread_t *kb_thread = thread_create(kbox_thread_proc, NULL, task,
+                    THREAD_FLAG_NONE, "kbox");
+                
+                if (!kb_thread) {
+                        mutex_unlock(&task->kb.cleanup_lock);
+                        return ENOMEM;
+                }
+                
+                task->kb.thread = kb_thread;
+                thread_ready(kb_thread);
+        }
+        
+        /* Allocate a new phone. */
+        cap_handle_t phone_handle;
+        errno_t rc = phone_alloc(TASK, &phone_handle);
+        if (rc != EOK) {
                 mutex_unlock(&task->kb.cleanup_lock);
-                return phone_handle;
+                return rc;
         }
         
@@ -248 +265 @@
         (void) ipc_phone_connect(phone_obj->phone, &task->kb.box);
         
-        if (task->kb.thread != NULL) {
-                mutex_unlock(&task->kb.cleanup_lock);
-                return phone_handle;
-        }
-        
-        /* Create a kbox thread */
-        thread_t *kb_thread = thread_create(kbox_thread_proc, NULL, task,
-            THREAD_FLAG_NONE, "kbox");
-        if (!kb_thread) {
-                mutex_unlock(&task->kb.cleanup_lock);
-                return ENOMEM;
-        }
-        
-        task->kb.thread = kb_thread;
-        thread_ready(kb_thread);
-        
         mutex_unlock(&task->kb.cleanup_lock);
-        
-        return phone_handle;
+        *out_phone = phone_handle;
+        return EOK;
 }