Changeset b7fd2a0 in mainline for kernel/generic/src/proc/thread.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• kernel/generic/src/proc/thread.c (modified) (11 diffs)

kernel/generic/src/proc/thread.c

@@ -153 +153 @@
  *
  */
-static int thr_constructor(void *obj, unsigned int kmflags)
+static errno_t thr_constructor(void *obj, unsigned int kmflags)
 {
         thread_t *thread = (thread_t *) obj;
@@ -639 +639 @@
  *
  */
-int thread_join_timeout(thread_t *thread, uint32_t usec, unsigned int flags)
+errno_t thread_join_timeout(thread_t *thread, uint32_t usec, unsigned int flags)
 {
         if (thread == THREAD)
@@ -930 +930 @@
  *
  */
-sysarg_t sys_thread_create(uspace_arg_t *uspace_uarg, char *uspace_name,
+sys_errno_t sys_thread_create(uspace_arg_t *uspace_uarg, char *uspace_name,
     size_t name_len, thread_id_t *uspace_thread_id)
 {
@@ -937 +937 @@
         
         char namebuf[THREAD_NAME_BUFLEN];
-        int rc = copy_from_uspace(namebuf, uspace_name, name_len);
+        errno_t rc = copy_from_uspace(namebuf, uspace_name, name_len);
         if (rc != 0)
-                return (sysarg_t) rc;
+                return (sys_errno_t) rc;
         
         namebuf[name_len] = 0;
@@ -953 +953 @@
         if (rc != 0) {
                 free(kernel_uarg);
-                return (sysarg_t) rc;
+                return (sys_errno_t) rc;
         }
         
@@ -977 +977 @@
                                 free(kernel_uarg);
                                 
-                                return (sysarg_t) rc;
+                                return (sys_errno_t) rc;
                          }
                 }
@@ -999 +999 @@
                 free(kernel_uarg);
         
-        return (sysarg_t) ENOMEM;
+        return (sys_errno_t) ENOMEM;
 }
 
@@ -1005 +1005 @@
  *
  */
-sysarg_t sys_thread_exit(int uspace_status)
+sys_errno_t sys_thread_exit(int uspace_status)
 {
         thread_exit();
@@ -1018 +1018 @@
  *
  */
-sysarg_t sys_thread_get_id(thread_id_t *uspace_thread_id)
+sys_errno_t sys_thread_get_id(thread_id_t *uspace_thread_id)
 {
         /*
@@ -1025 +1025 @@
          *
          */
-        return (sysarg_t) copy_to_uspace(uspace_thread_id, &THREAD->tid,
+        return (sys_errno_t) copy_to_uspace(uspace_thread_id, &THREAD->tid,
             sizeof(THREAD->tid));
 }
 
 /** Syscall wrapper for sleeping. */
-sysarg_t sys_thread_usleep(uint32_t usec)
+sys_errno_t sys_thread_usleep(uint32_t usec)
 {
         thread_usleep(usec);
@@ -1036 +1036 @@
 }
 
-sysarg_t sys_thread_udelay(uint32_t usec)
+sys_errno_t sys_thread_udelay(uint32_t usec)
 {
         delay(usec);