Changeset b7fd2a0 in mainline for uspace/app/devctl/devctl.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/devctl/devctl.c (modified) (12 diffs)

uspace/app/devctl/devctl.c

@@ -70 +70 @@
 }
 
-static int fun_subtree_print(devman_handle_t funh, int lvl)
+static errno_t fun_subtree_print(devman_handle_t funh, int lvl)
 {
         devman_handle_t devh;
@@ -76 +76 @@
         size_t count, i;
         unsigned int score;
-        int rc;
+        errno_t rc;
         int j;
 
@@ -136 +136 @@
 }
 
-static int fun_tree_print(void)
+static errno_t fun_tree_print(void)
 {
         devman_handle_t root_fun;
-        int rc;
+        errno_t rc;
 
         rc = devman_fun_get_handle("/", &root_fun, 0);
@@ -154 +154 @@
 }
 
-static int fun_online(const char *path)
+static errno_t fun_online(const char *path)
 {
         devman_handle_t funh;
-        int rc;
+        errno_t rc;
 
         rc = devman_fun_get_handle(path, &funh, 0);
@@ -175 +175 @@
 }
 
-static int fun_offline(const char *path)
+static errno_t fun_offline(const char *path)
 {
         devman_handle_t funh;
-        int rc;
+        errno_t rc;
 
         rc = devman_fun_get_handle(path, &funh, 0);
@@ -197 +197 @@
 }
 
-static int drv_list(void)
+static errno_t drv_list(void)
 {
         devman_handle_t *devs;
@@ -207 +207 @@
         size_t i;
         table_t *table = NULL;
-        int rc;
+        errno_t rc;
 
         rc = devman_get_drivers(&drvs, &ndrvs);
@@ -252 +252 @@
 }
 
-static int drv_show(char *drvname)
+static errno_t drv_show(char *drvname)
 {
         devman_handle_t *devs;
@@ -262 +262 @@
         size_t ndevs;
         size_t i;
-        int rc;
+        errno_t rc;
 
         rc = devman_driver_get_handle(drvname, &drvh);
@@ -317 +317 @@
 }
 
-static int drv_load(const char *drvname)
-{
-        int rc;
+static errno_t drv_load(const char *drvname)
+{
+        errno_t rc;
         devman_handle_t drvh;
 
@@ -337 +337 @@
 }
 
-static int drv_unload(const char *drvname)
-{
-        int rc;
+static errno_t drv_unload(const char *drvname)
+{
+        errno_t rc;
         devman_handle_t drvh;
 
@@ -371 +371 @@
 int main(int argc, char *argv[])
 {
-        int rc;
+        errno_t rc;
 
         if (argc == 1 || argv[1][0] == '-') {