Changeset b7fd2a0 in mainline for uspace/app/mkfat/mkfat.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/mkfat/mkfat.c (modified) (6 diffs)

uspace/app/mkfat/mkfat.c

@@ -86 +86 @@
 static void syntax_print(void);
 
-static int fat_params_compute(struct fat_cfg *cfg);
-static int fat_blocks_write(struct fat_cfg const *cfg, service_id_t service_id);
+static errno_t fat_params_compute(struct fat_cfg *cfg);
+static errno_t fat_blocks_write(struct fat_cfg const *cfg, service_id_t service_id);
 static void fat_bootsec_create(struct fat_cfg const *cfg, struct fat_bs *bs);
 
@@ -94 +94 @@
         struct fat_cfg cfg;
 
-        int rc;
+        errno_t rc;
         char *dev_path;
         service_id_t service_id;
@@ -252 +252 @@
 }
 
-static int fat_label_encode(void *dest, const char *src)
+static errno_t fat_label_encode(void *dest, const char *src)
 {
         int i;
@@ -284 +284 @@
  * file system params.
  */
-static int fat_params_compute(struct fat_cfg *cfg)
+static errno_t fat_params_compute(struct fat_cfg *cfg)
 {
         uint32_t fat_bytes;
@@ -356 +356 @@
 
 /** Create file system with the given parameters. */
-static int fat_blocks_write(struct fat_cfg const *cfg, service_id_t service_id)
+static errno_t fat_blocks_write(struct fat_cfg const *cfg, service_id_t service_id)
 {
         aoff64_t addr;
@@ -362 +362 @@
         int i;
         uint32_t j;
-        int rc;
+        errno_t rc;
         struct fat_bs bs;
         fat_dentry_t *de;