Changeset b7fd2a0 in mainline for uspace/app/sbi/src/os/helenos.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/sbi/src/os/helenos.c (modified) (3 diffs)

uspace/app/sbi/src/os/helenos.c

@@ -151 +151 @@
  *                      EIO on decoding error.
  */
-int os_str_get_char(const char *str, int index, int *out_char)
+errno_t os_str_get_char(const char *str, int index, int *out_char)
 {
         size_t offset;
@@ -210 +210 @@
  * @param ptr   Place to store pointer to new string.
  */
-int os_input_line(const char *prompt, char **ptr)
+errno_t os_input_line(const char *prompt, char **ptr)
 {
         char *line;
-        int rc;
+        errno_t rc;
 
         if (tinput == NULL) {
@@ -247 +247 @@
  *              Command is present just one, not duplicated.
  */
-int os_exec(char *const cmd[])
+errno_t os_exec(char *const cmd[])
 {
         task_id_t tid;
         task_wait_t twait;
         task_exit_t texit;
-        int rc;
+        errno_t rc;
         int retval;