Changeset b7fd2a0 in mainline for uspace/drv/audio/hdaudio/hdactl.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/audio/hdaudio/hdactl.c (modified) (12 diffs)

uspace/drv/audio/hdaudio/hdactl.c

@@ -64 +64 @@
  * to read as 0.
  */
-static int hda_ctl_reg16_set_reset(uint16_t *reg, uint16_t mask)
+static errno_t hda_ctl_reg16_set_reset(uint16_t *reg, uint16_t mask)
 {
         uint16_t val;
@@ -116 +116 @@
  *
  */
-static int hda_rb_size_select(uint8_t sizecap, uint8_t *selsz)
+static errno_t hda_rb_size_select(uint8_t sizecap, uint8_t *selsz)
 {
         int i;
@@ -146 +146 @@
 
 /** Initialize the CORB */
-static int hda_corb_init(hda_t *hda)
+static errno_t hda_corb_init(hda_t *hda)
 {
         uint8_t ctl;
@@ -152 +152 @@
         uint8_t sizecap;
         uint8_t selsz;
-        int rc;
+        errno_t rc;
 
         ddf_msg(LVL_NOTE, "hda_corb_init()");
@@ -237 +237 @@
 
 /** Initialize the RIRB */
-static int hda_rirb_init(hda_t *hda)
+static errno_t hda_rirb_init(hda_t *hda)
 {
         uint8_t ctl;
@@ -243 +243 @@
         uint8_t sizecap;
         uint8_t selsz;
-        int rc;
+        errno_t rc;
 
         ddf_msg(LVL_NOTE, "hda_rirb_init()");
@@ -372 +372 @@
 
 /** Write to CORB */
-static int hda_corb_write(hda_t *hda, uint32_t *data, size_t count)
+static errno_t hda_corb_write(hda_t *hda, uint32_t *data, size_t count)
 {
         size_t avail;
@@ -414 +414 @@
 }
 
-static int hda_rirb_read(hda_t *hda, hda_rirb_entry_t *data)
+static errno_t hda_rirb_read(hda_t *hda, hda_rirb_entry_t *data)
 {
         size_t wp;
@@ -436 +436 @@
 }
 
-static int hda_solrb_read(hda_t *hda, hda_rirb_entry_t *data, size_t count)
+static errno_t hda_solrb_read(hda_t *hda, hda_rirb_entry_t *data, size_t count)
 {
         hda_rirb_entry_t resp;
@@ -490 +490 @@
         uint32_t intctl;
         int cnt;
-        int rc;
+        errno_t rc;
 
         ctl = calloc(1, sizeof(hda_ctl_t));
@@ -615 +615 @@
 }
 
-int hda_cmd(hda_t *hda, uint32_t verb, uint32_t *resp)
-{
-        int rc;
+errno_t hda_cmd(hda_t *hda, uint32_t verb, uint32_t *resp)
+{
+        errno_t rc;
         hda_rirb_entry_t rentry;
 
@@ -639 +639 @@
 {
         hda_rirb_entry_t resp;
-        int rc;
+        errno_t rc;
 
         while (true) {