Changes in uspace/drv/audio/sb16/dsp.c [53a309e:b7fd2a0] in mainline

File:

• uspace/drv/audio/sb16/dsp.c (modified) (17 diffs)

uspace/drv/audio/sb16/dsp.c

@@ -89 +89 @@
 }
 
-static inline int dsp_read(sb_dsp_t *dsp, uint8_t *data)
+static inline errno_t dsp_read(sb_dsp_t *dsp, uint8_t *data)
 {
         assert(data);
@@ -106 +106 @@
 }
 
-static inline int dsp_write(sb_dsp_t *dsp, uint8_t data)
+static inline errno_t dsp_write(sb_dsp_t *dsp, uint8_t data)
 {
         assert(dsp);
@@ -159 +159 @@
 }
 
-static inline int setup_dma(sb_dsp_t *dsp, uintptr_t pa, size_t size)
+static inline errno_t setup_dma(sb_dsp_t *dsp, uintptr_t pa, size_t size)
 {
         async_sess_t *sess = ddf_dev_parent_sess_get(dsp->sb_dev);
@@ -168 +168 @@
 }
 
-static inline int setup_buffer(sb_dsp_t *dsp, size_t size)
+static inline errno_t setup_buffer(sb_dsp_t *dsp, size_t size)
 {
         assert(dsp);
@@ -178 +178 @@
         void *buffer = AS_AREA_ANY;
         
-        int ret = dmamem_map_anonymous(size, DMAMEM_16MiB | 0x0000ffff,
+        errno_t ret = dmamem_map_anonymous(size, DMAMEM_16MiB | 0x0000ffff,
             AS_AREA_WRITE | AS_AREA_READ, 0, &pa, &buffer);
         if (ret != EOK) {
@@ -202 +202 @@
 }
 
-int sb_dsp_init(sb_dsp_t *dsp, sb16_regs_t *regs, ddf_dev_t *dev,
+errno_t sb_dsp_init(sb_dsp_t *dsp, sb16_regs_t *regs, ddf_dev_t *dev,
     int dma8, int dma16)
 {
@@ -215 +215 @@
         dsp_reset(dsp);
         uint8_t response;
-        const int ret = dsp_read(dsp, &response);
+        const errno_t ret = dsp_read(dsp, &response);
         if (ret != EOK) {
                 ddf_log_error("Failed to read DSP reset response value.");
@@ -290 +290 @@
                 return 16535;
         default:
-                return ENOTSUP;
-        }
-}
-
-int sb_dsp_get_buffer_position(sb_dsp_t *dsp, size_t *pos)
+                return -1;
+        }
+}
+
+errno_t sb_dsp_get_buffer_position(sb_dsp_t *dsp, size_t *pos)
 {
         if (dsp->state == DSP_NO_BUFFER)
@@ -303 +303 @@
 
         // TODO: Assumes DMA 16
-        const int remain = hw_res_dma_channel_remain(sess, dsp->dma16_channel);
-        if (remain >= 0) {
+        size_t remain;
+        errno_t rc = hw_res_dma_channel_remain(sess, dsp->dma16_channel, &remain);
+        if (rc == EOK) {
                 *pos = dsp->buffer.size - remain;
-                return EOK;
-        }
-        return remain;
-}
-
-int sb_dsp_test_format(sb_dsp_t *dsp, unsigned *channels, unsigned *rate,
+        }
+        return rc;
+}
+
+errno_t sb_dsp_test_format(sb_dsp_t *dsp, unsigned *channels, unsigned *rate,
   pcm_sample_format_t *format)
 {
-        int ret = EOK;
+        errno_t ret = EOK;
         if (*channels == 0 || *channels > 2) {
                 *channels = 2;
@@ -336 +336 @@
 }
 
-int sb_dsp_set_event_session(sb_dsp_t *dsp, async_sess_t *session)
+errno_t sb_dsp_set_event_session(sb_dsp_t *dsp, async_sess_t *session)
 {
         assert(dsp);
@@ -353 +353 @@
 }
 
-int sb_dsp_get_buffer(sb_dsp_t *dsp, void **buffer, size_t *size)
+errno_t sb_dsp_get_buffer(sb_dsp_t *dsp, void **buffer, size_t *size)
 {
         assert(dsp);
@@ -364 +364 @@
         assert(dsp->buffer.data == NULL);
 
-        const int ret = setup_buffer(dsp, *size);
+        const errno_t ret = setup_buffer(dsp, *size);
         if (ret == EOK) {
                 ddf_log_debug("Providing buffer: %p, %zu B.",
@@ -378 +378 @@
 }
 
-int sb_dsp_release_buffer(sb_dsp_t *dsp)
+errno_t sb_dsp_release_buffer(sb_dsp_t *dsp)
 {
         assert(dsp);
@@ -392 +392 @@
 }
 
-int sb_dsp_start_playback(sb_dsp_t *dsp, unsigned frames,
+errno_t sb_dsp_start_playback(sb_dsp_t *dsp, unsigned frames,
     unsigned channels, unsigned sampling_rate, pcm_sample_format_t format)
 {
@@ -441 +441 @@
 }
 
-int sb_dsp_stop_playback(sb_dsp_t *dsp, bool immediate)
+errno_t sb_dsp_stop_playback(sb_dsp_t *dsp, bool immediate)
 {
         assert(dsp);
@@ -471 +471 @@
 }
 
-int sb_dsp_start_capture(sb_dsp_t *dsp, unsigned frames,
+errno_t sb_dsp_start_capture(sb_dsp_t *dsp, unsigned frames,
     unsigned channels, unsigned sampling_rate, pcm_sample_format_t format)
 {
@@ -517 +517 @@
 }
 
-int sb_dsp_stop_capture(sb_dsp_t *dsp, bool immediate)
+errno_t sb_dsp_stop_capture(sb_dsp_t *dsp, bool immediate)
 {
         assert(dsp);