Changeset b7fd2a0 in mainline for uspace/drv/audio/sb16/main.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/audio/sb16/main.c (modified) (6 diffs)

uspace/drv/audio/sb16/main.c

@@ -47 +47 @@
 #define NAME "sb16"
 
-static int sb_add_device(ddf_dev_t *device);
-static int sb_get_res(ddf_dev_t *device, addr_range_t **pp_sb_regs,
+static errno_t sb_add_device(ddf_dev_t *device);
+static errno_t sb_get_res(ddf_dev_t *device, addr_range_t **pp_sb_regs,
     addr_range_t **pp_mpu_regs, int *irq, int *dma8, int *dma16);
-static int sb_enable_interrupt(ddf_dev_t *device, int irq);
+static errno_t sb_enable_interrupt(ddf_dev_t *device, int irq);
 
 static driver_ops_t sb_driver_ops = {
@@ -87 +87 @@
  * @return Error code.
  */
-static int sb_add_device(ddf_dev_t *device)
+static errno_t sb_add_device(ddf_dev_t *device)
 {
         bool handler_regd = false;
@@ -96 +96 @@
 
         sb16_t *soft_state = ddf_dev_data_alloc(device, sizeof(sb16_t));
-        int rc = soft_state ? EOK : ENOMEM;
+        errno_t rc = soft_state ? EOK : ENOMEM;
         if (rc != EOK) {
                 ddf_log_error("Failed to allocate sb16 structure.");
@@ -173 +173 @@
 }
 
-static int sb_get_res(ddf_dev_t *device, addr_range_t **pp_sb_regs,
+static errno_t sb_get_res(ddf_dev_t *device, addr_range_t **pp_sb_regs,
     addr_range_t **pp_mpu_regs, int *irq, int *dma8, int *dma16)
 {
@@ -184 +184 @@
         hw_res_list_parsed_t hw_res;
         hw_res_list_parsed_init(&hw_res);
-        const int ret = hw_res_get_list_parsed(parent_sess, &hw_res, 0);
+        const errno_t ret = hw_res_get_list_parsed(parent_sess, &hw_res, 0);
         if (ret != EOK) {
                 return ret;
@@ -241 +241 @@
 }
 
-static int sb_enable_interrupt(ddf_dev_t *device, int irq)
+static errno_t sb_enable_interrupt(ddf_dev_t *device, int irq)
 {
         async_sess_t *parent_sess = ddf_dev_parent_sess_get(device);