Changeset b7fd2a0 in mainline for uspace/drv/bus/usb/usbmid/explore.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/bus/usb/usbmid/explore.c (modified) (4 diffs)

uspace/drv/bus/usb/usbmid/explore.c

@@ -66 +66 @@
  * @param list List where to add the interfaces.
  */
-static int create_interfaces(const uint8_t *config_descriptor,
+static errno_t create_interfaces(const uint8_t *config_descriptor,
     size_t config_descriptor_size, list_t *list, usb_device_t *usb_dev)
 {
@@ -111 +111 @@
 
                 usbmid_interface_t *iface = NULL;
-                const int rc = usbmid_spawn_interface_child(usb_dev, &iface,
+                const errno_t rc = usbmid_spawn_interface_child(usb_dev, &iface,
                         &usb_device_descriptors(usb_dev)->device, interface);
                 if (rc != EOK) {
@@ -134 +134 @@
  * @return Whether to accept this device.
  */
-int usbmid_explore_device(usb_device_t *dev)
+errno_t usbmid_explore_device(usb_device_t *dev)
 {
         assert(dev);
@@ -157 +157 @@
 
         /* Select the first configuration */
-        int rc = usb_request_set_configuration(usb_device_get_default_pipe(dev),
+        errno_t rc = usb_request_set_configuration(usb_device_get_default_pipe(dev),
             config_descriptor->configuration_number);
         if (rc != EOK) {