Changeset b7fd2a0 in mainline for uspace/drv/bus/usb/usbmid/usbmid.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/bus/usb/usbmid/usbmid.c (modified) (5 diffs)

uspace/drv/bus/usb/usbmid/usbmid.c

@@ -51 +51 @@
  * @return Error code.
  */
-static int usb_iface_device_handle(ddf_fun_t *fun, devman_handle_t *handle)
+static errno_t usb_iface_device_handle(ddf_fun_t *fun, devman_handle_t *handle)
 {
         assert(fun);
@@ -61 +61 @@
 
 /** Callback for DDF USB get interface. */
-static int usb_iface_iface_no(ddf_fun_t *fun, int *iface_no)
+static errno_t usb_iface_iface_no(ddf_fun_t *fun, int *iface_no)
 {
         usbmid_interface_t *iface = ddf_fun_data_get(fun);
@@ -83 +83 @@
 };
 
-int usbmid_interface_destroy(usbmid_interface_t *mid_iface)
+errno_t usbmid_interface_destroy(usbmid_interface_t *mid_iface)
 {
         assert(mid_iface);
         assert_link_not_used(&mid_iface->link);
-        const int ret = ddf_fun_unbind(mid_iface->fun);
+        const errno_t ret = ddf_fun_unbind(mid_iface->fun);
         if (ret != EOK) {
                 return ret;
@@ -103 +103 @@
  * @return Error code.
  */
-int usbmid_spawn_interface_child(usb_device_t *parent,
+errno_t usbmid_spawn_interface_child(usb_device_t *parent,
     usbmid_interface_t **iface_ret,
     const usb_standard_device_descriptor_t *device_descriptor,
@@ -110 +110 @@
         ddf_fun_t *child = NULL;
         char *child_name = NULL;
-        int rc;
+        errno_t rc;
 
         /*