Changes in uspace/drv/char/ns8250/ns8250.c [38d150e:b7fd2a0] in mainline

File:

• uspace/drv/char/ns8250/ns8250.c (modified) (21 diffs)

uspace/drv/char/ns8250/ns8250.c

@@ -40 +40 @@
 #include <stdio.h>
 #include <errno.h>
+#include <str_error.h>
 #include <stdbool.h>
 #include <fibril_synch.h>
@@ -250 +251 @@
  * @return              EOK on success or non-zero error code
  */
-static int ns8250_read(chardev_srv_t *srv, void *buf, size_t count, size_t *nread)
+static errno_t ns8250_read(chardev_srv_t *srv, void *buf, size_t count, size_t *nread)
 {
         ns8250_t *ns = srv_ns8250(srv);
@@ -294 +295 @@
  * @return              EOK on success or non-zero error code
  */
-static int ns8250_write(chardev_srv_t *srv, const void *buf, size_t count,
+static errno_t ns8250_write(chardev_srv_t *srv, const void *buf, size_t count,
     size_t *nwritten)
 {
@@ -308 +309 @@
 }
 
-static int ns8250_open(chardev_srvs_t *, chardev_srv_t *);
-static int ns8250_close(chardev_srv_t *);
+static errno_t ns8250_open(chardev_srvs_t *, chardev_srv_t *);
+static errno_t ns8250_close(chardev_srv_t *);
 static void ns8250_default_handler(chardev_srv_t *, ipc_callid_t, ipc_call_t *);
 
@@ -323 +324 @@
 static void ns8250_char_conn(ipc_callid_t, ipc_call_t *, void *);
 
-static int ns8250_dev_add(ddf_dev_t *dev);
-static int ns8250_dev_remove(ddf_dev_t *dev);
+static errno_t ns8250_dev_add(ddf_dev_t *dev);
+static errno_t ns8250_dev_remove(ddf_dev_t *dev);
 
 /** The serial port device driver's standard operations. */
@@ -404 +405 @@
  *
  * @param ns            Serial port device
- * @return              Zero on success, negative error number otherwise
- */
-static int ns8250_dev_initialize(ns8250_t *ns)
-{
-        int ret = EOK;
+ * @return              Zero on success, error number otherwise
+ */
+static errno_t ns8250_dev_initialize(ns8250_t *ns)
+{
+        errno_t ret = EOK;
         
         ddf_msg(LVL_DEBUG, "ns8250_dev_initialize %s", ddf_dev_get_name(ns->dev));
@@ -498 +499 @@
  *
  * @param ns            Serial port device
- * @return              Zero on success, negative error number otherwise
- */
-static int ns8250_interrupt_enable(ns8250_t *ns)
+ * @return              Zero on success, error number otherwise
+ */
+static errno_t ns8250_interrupt_enable(ns8250_t *ns)
 {
         /* Enable interrupt using IRC service. */
-        int rc = hw_res_enable_interrupt(ns->parent_sess, ns->irq);
+        errno_t rc = hw_res_enable_interrupt(ns->parent_sess, ns->irq);
         if (rc != EOK)
                 return EIO;
@@ -543 +544 @@
  * @param port          The base address of the serial port device's ports.
  * @param baud_rate     The baud rate to be used by the device.
- * @return              Zero on success, negative error number otherwise (EINVAL
+ * @return              Zero on success, error number otherwise (EINVAL
  *                      if the specified baud_rate is not valid).
  */
-static int ns8250_port_set_baud_rate(ns8250_regs_t *regs, unsigned int baud_rate)
+static errno_t ns8250_port_set_baud_rate(ns8250_regs_t *regs, unsigned int baud_rate)
 {
         uint16_t divisor;
@@ -645 +646 @@
  *                      is invalid.
  */
-static int ns8250_port_set_com_props(ns8250_regs_t *regs, unsigned int parity,
+static errno_t ns8250_port_set_com_props(ns8250_regs_t *regs, unsigned int parity,
     unsigned int word_length, unsigned int stop_bits)
 {
@@ -802 +803 @@
  * @param ns            Serial port device
  */
-static inline int ns8250_register_interrupt_handler(ns8250_t *ns)
+static inline errno_t ns8250_register_interrupt_handler(ns8250_t *ns,
+    cap_handle_t *handle)
 {
         return register_interrupt_handler(ns->dev, ns->irq,
-            ns8250_interrupt_handler, NULL);
+            ns8250_interrupt_handler, NULL, handle);
 }
 
@@ -812 +814 @@
  * @param ns            Serial port device
  */
-static inline int ns8250_unregister_interrupt_handler(ns8250_t *ns)
+static inline errno_t ns8250_unregister_interrupt_handler(ns8250_t *ns)
 {
         return unregister_interrupt_handler(ns->dev, ns->irq_cap);
@@ -823 +825 @@
  * @param dev           The serial port device.
  */
-static int ns8250_dev_add(ddf_dev_t *dev)
+static errno_t ns8250_dev_add(ddf_dev_t *dev)
 {
         ns8250_t *ns = NULL;
@@ -829 +831 @@
         bool need_cleanup = false;
         bool need_unreg_intr_handler = false;
-        int rc;
+        errno_t rc;
         
         ddf_msg(LVL_DEBUG, "ns8250_dev_add %s (handle = %d)",
@@ -874 +876 @@
         
         /* Register interrupt handler. */
-        ns->irq_cap = ns8250_register_interrupt_handler(ns);
-        if (ns->irq_cap < 0) {
+        rc = ns8250_register_interrupt_handler(ns, &ns->irq_cap);
+        if (rc != EOK) {
                 ddf_msg(LVL_ERROR, "Failed to register interrupt handler.");
                 rc = EADDRNOTAVAIL;
@@ -886 +888 @@
         if (rc != EOK) {
                 ddf_msg(LVL_ERROR, "Failed to enable the interrupt. Error code = "
-                    "%d.", rc);
+                    "%s.", str_error_name(rc));
                 goto fail;
         }
@@ -926 +928 @@
 }
 
-static int ns8250_dev_remove(ddf_dev_t *dev)
+static errno_t ns8250_dev_remove(ddf_dev_t *dev)
 {
         ns8250_t *ns = dev_ns8250(dev);
-        int rc;
+        errno_t rc;
         
         fibril_mutex_lock(&ns->mutex);
@@ -961 +963 @@
  * @param srv           Server-side connection structure
  */
-static int ns8250_open(chardev_srvs_t *srvs, chardev_srv_t *srv)
+static errno_t ns8250_open(chardev_srvs_t *srvs, chardev_srv_t *srv)
 {
         ns8250_t *ns = srv_ns8250(srv);
-        int res;
+        errno_t res;
         
         fibril_mutex_lock(&ns->mutex);
@@ -985 +987 @@
  * @param srv           Server-side connection structure
  */
-static int ns8250_close(chardev_srv_t *srv)
+static errno_t ns8250_close(chardev_srv_t *srv)
 {
         ns8250_t *data = srv_ns8250(srv);
@@ -1038 +1040 @@
  * @param stop_bits     The number of stop bits to be used.
  */
-static int ns8250_set_props(ddf_dev_t *dev, unsigned int baud_rate,
+static errno_t ns8250_set_props(ddf_dev_t *dev, unsigned int baud_rate,
     unsigned int parity, unsigned int word_length, unsigned int stop_bits)
 {
@@ -1047 +1049 @@
         ns8250_t *data = dev_ns8250(dev);
         ns8250_regs_t *regs = data->regs;
-        int ret;
+        errno_t ret;
         
         fibril_mutex_lock(&data->mutex);
@@ -1070 +1072 @@
         ns8250_t *ns8250 = srv_ns8250(srv);
         sysarg_t method = IPC_GET_IMETHOD(*call);
-        int ret;
+        errno_t ret;
         unsigned int baud_rate, parity, word_length, stop_bits;