Changeset b7fd2a0 in mainline for uspace/drv/hid/adb-kbd/adb-kbd.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/hid/adb-kbd/adb-kbd.c (modified) (5 diffs)

uspace/drv/hid/adb-kbd/adb-kbd.c

@@ -48 +48 @@
 
 /** Add ADB keyboard device */
-int adb_kbd_add(adb_kbd_t *kbd)
-{
-        int rc;
+errno_t adb_kbd_add(adb_kbd_t *kbd)
+{
+        errno_t rc;
         bool bound = false;
 
@@ -119 +119 @@
 
 /** Remove ADB keyboard device */
-int adb_kbd_remove(adb_kbd_t *con)
+errno_t adb_kbd_remove(adb_kbd_t *con)
 {
         return ENOTSUP;
@@ -125 +125 @@
 
 /** ADB keyboard device gone */
-int adb_kbd_gone(adb_kbd_t *con)
+errno_t adb_kbd_gone(adb_kbd_t *con)
 {
         return ENOTSUP;
@@ -140 +140 @@
                 ipc_callid_t callid = async_get_call(&call);
 
-                int retval = EOK;
+                errno_t retval = EOK;
 
                 if (!IPC_GET_IMETHOD(call)) {
@@ -162 +162 @@
         kbd_event_type_t etype;
         unsigned int key;
-        int rc;
+        errno_t rc;
 
         rc = adb_kbd_key_translate(b, &etype, &key);