Changeset b7fd2a0 in mainline for uspace/drv/hid/adb-kbd/main.c


Ignore:
Timestamp:
2018-01-13T03:10:29Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • uspace/drv/hid/adb-kbd/main.c

    r36f0738 rb7fd2a0  
    4242#define NAME  "adb-kbd"
    4343
    44 static int adb_kbd_dev_add(ddf_dev_t *dev);
    45 static int adb_kbd_dev_remove(ddf_dev_t *dev);
    46 static int adb_kbd_dev_gone(ddf_dev_t *dev);
    47 static int adb_kbd_fun_online(ddf_fun_t *fun);
    48 static int adb_kbd_fun_offline(ddf_fun_t *fun);
     44static errno_t adb_kbd_dev_add(ddf_dev_t *dev);
     45static errno_t adb_kbd_dev_remove(ddf_dev_t *dev);
     46static errno_t adb_kbd_dev_gone(ddf_dev_t *dev);
     47static errno_t adb_kbd_fun_online(ddf_fun_t *fun);
     48static errno_t adb_kbd_fun_offline(ddf_fun_t *fun);
    4949
    5050static driver_ops_t driver_ops = {
    … …  
    6161};
    6262
    63 static int adb_kbd_dev_add(ddf_dev_t *dev)
     63static errno_t adb_kbd_dev_add(ddf_dev_t *dev)
    6464{
    6565        adb_kbd_t *adb_kbd;
    … …  
    7777}
    7878
    79 static int adb_kbd_dev_remove(ddf_dev_t *dev)
     79static errno_t adb_kbd_dev_remove(ddf_dev_t *dev)
    8080{
    8181        adb_kbd_t *adb_kbd = (adb_kbd_t *)ddf_dev_data_get(dev);
    … …  
    8686}
    8787
    88 static int adb_kbd_dev_gone(ddf_dev_t *dev)
     88static errno_t adb_kbd_dev_gone(ddf_dev_t *dev)
    8989{
    9090        adb_kbd_t *adb_kbd = (adb_kbd_t *)ddf_dev_data_get(dev);
    … …  
    9595}
    9696
    97 static int adb_kbd_fun_online(ddf_fun_t *fun)
     97static errno_t adb_kbd_fun_online(ddf_fun_t *fun)
    9898{
    9999        ddf_msg(LVL_DEBUG, "adb_kbd_fun_online()");
    … …  
    101101}
    102102
    103 static int adb_kbd_fun_offline(ddf_fun_t *fun)
     103static errno_t adb_kbd_fun_offline(ddf_fun_t *fun)
    104104{
    105105        ddf_msg(LVL_DEBUG, "adb_kbd_fun_offline()");
Note: See TracChangeset for help on using the changeset viewer.