Changeset b7fd2a0 in mainline for uspace/drv/hid/usbhid/generic/hiddev.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/hid/usbhid/generic/hiddev.c (modified) (6 diffs)

uspace/drv/hid/usbhid/generic/hiddev.c

@@ -60 +60 @@
 
 static size_t usb_generic_hid_get_event_length(ddf_fun_t *fun);
-static int usb_generic_hid_get_event(ddf_fun_t *fun, uint8_t *buffer,
+static errno_t usb_generic_hid_get_event(ddf_fun_t *fun, uint8_t *buffer,
     size_t size, size_t *act_size, int *event_nr, unsigned int flags);
-static int usb_generic_hid_client_connected(ddf_fun_t *fun);
+static errno_t usb_generic_hid_client_connected(ddf_fun_t *fun);
 static size_t usb_generic_get_report_descriptor_length(ddf_fun_t *fun);
-static int usb_generic_get_report_descriptor(ddf_fun_t *fun, uint8_t *desc,
+static errno_t usb_generic_get_report_descriptor(ddf_fun_t *fun, uint8_t *desc,
     size_t size, size_t *actual_size);
 
@@ -102 +102 @@
 }
 
-static int usb_generic_hid_get_event(ddf_fun_t *fun, uint8_t *buffer,
+static errno_t usb_generic_hid_get_event(ddf_fun_t *fun, uint8_t *buffer,
     size_t size, size_t *act_size, int *event_nr, unsigned int flags)
 {
@@ -143 +143 @@
 }
 
-static int usb_generic_get_report_descriptor(ddf_fun_t *fun, uint8_t *desc,
+static errno_t usb_generic_get_report_descriptor(ddf_fun_t *fun, uint8_t *desc,
     size_t size, size_t *actual_size)
 {
@@ -160 +160 @@
 }
 
-static int usb_generic_hid_client_connected(ddf_fun_t *fun)
+static errno_t usb_generic_hid_client_connected(ddf_fun_t *fun)
 {
         usb_log_debug("Generic HID: Client connected.\n");
@@ -180 +180 @@
 }
 
-int usb_generic_hid_init(usb_hid_dev_t *hid_dev, void **data)
+errno_t usb_generic_hid_init(usb_hid_dev_t *hid_dev, void **data)
 {
         usb_hid_gen_fun_t *hid_fun;
@@ -202 +202 @@
         ddf_fun_set_ops(fun, &usb_generic_hid_ops);
 
-        int rc = ddf_fun_bind(fun);
+        errno_t rc = ddf_fun_bind(fun);
         if (rc != EOK) {
                 usb_log_error("Could not bind DDF function: %s.\n",