Changes in uspace/drv/hid/usbhid/mouse/mousedev.c [5a6cc679:b7fd2a0] in mainline

File:

• uspace/drv/hid/usbhid/mouse/mousedev.c (modified) (18 diffs)

uspace/drv/hid/usbhid/mouse/mousedev.c

@@ -118 +118 @@
 
         if (mouse_dev == NULL) {
-                usb_log_debug("%s: Missing parameters.", __FUNCTION__);
+                usb_log_debug("%s: Missing parameters.\n", __FUNCTION__);
                 async_answer_0(icallid, EINVAL);
                 return;
         }
 
-        usb_log_debug("%s: fun->name: %s", __FUNCTION__, ddf_fun_get_name(fun));
-        usb_log_debug("%s: mouse_sess: %p",
+        usb_log_debug("%s: fun->name: %s\n", __FUNCTION__, ddf_fun_get_name(fun));
+        usb_log_debug("%s: mouse_sess: %p\n",
             __FUNCTION__, mouse_dev->mouse_sess);
 
@@ -132 +132 @@
                 if (mouse_dev->mouse_sess == NULL) {
                         mouse_dev->mouse_sess = sess;
-                        usb_log_debug("Console session to %s set ok (%p).",
+                        usb_log_debug("Console session to %s set ok (%p).\n",
                             ddf_fun_get_name(fun), sess);
                         async_answer_0(icallid, EOK);
                 } else {
-                        usb_log_error("Console session to %s already set.",
+                        usb_log_error("Console session to %s already set.\n",
                             ddf_fun_get_name(fun));
                         async_answer_0(icallid, ELIMIT);
@@ -142 +142 @@
                 }
         } else {
-                usb_log_debug("%s: Invalid function.", __FUNCTION__);
+                usb_log_debug("%s: Invalid function.\n", __FUNCTION__);
                 async_answer_0(icallid, EINVAL);
         }
 }
 
-static const usb_hid_report_field_t *get_mouse_axis_move_field(uint8_t rid, usb_hid_report_t *report,
+static int get_mouse_axis_move_value(uint8_t rid, usb_hid_report_t *report,
     int32_t usage)
 {
+        int result = 0;
+
         usb_hid_report_path_t *path = usb_hid_report_path();
         usb_hid_report_path_append_item(path, USB_HIDUT_PAGE_GENERIC_DESKTOP,
@@ -156 +158 @@
         usb_hid_report_path_set_report_id(path, rid);
 
-        const usb_hid_report_field_t *field = usb_hid_report_get_sibling(
+        usb_hid_report_field_t *field = usb_hid_report_get_sibling(
             report, NULL, path, USB_HID_PATH_COMPARE_END,
             USB_HID_REPORT_TYPE_INPUT);
 
+        if (field != NULL) {
+                result = field->value;
+        }
+
         usb_hid_report_path_free(path);
 
-        return field;
-}
-
-static void usb_mouse_process_report(usb_hid_dev_t *hid_dev,
+        return result;
+}
+
+static bool usb_mouse_process_report(usb_hid_dev_t *hid_dev,
     usb_mouse_t *mouse_dev)
 {
@@ -171 +177 @@
 
         if (mouse_dev->mouse_sess == NULL) {
-                usb_log_warning(NAME " No console session.");
-                return;
-        }
-
-        const usb_hid_report_field_t *move_x = get_mouse_axis_move_field(
-            hid_dev->report_id, &hid_dev->report,
-            USB_HIDUT_USAGE_GENERIC_DESKTOP_X);
-        const usb_hid_report_field_t *move_y = get_mouse_axis_move_field(
-            hid_dev->report_id, &hid_dev->report,
-            USB_HIDUT_USAGE_GENERIC_DESKTOP_Y);
-        const usb_hid_report_field_t *wheel= get_mouse_axis_move_field(
-            hid_dev->report_id, &hid_dev->report,
-            USB_HIDUT_USAGE_GENERIC_DESKTOP_WHEEL);
-
-        bool absolute_x = move_x && !USB_HID_ITEM_FLAG_RELATIVE(move_x->item_flags);
-        bool absolute_y = move_y && !USB_HID_ITEM_FLAG_RELATIVE(move_y->item_flags);
-
-        /* Tablet shall always report both X and Y */
-        if (absolute_x != absolute_y) {
-                usb_log_error(NAME " cannot handle mix of absolute and relative mouse move.");
-                return;
-        }
-
-        int shift_x = move_x ? move_x->value : 0;
-        int shift_y = move_y ? move_y->value : 0;
-        int shift_z =  wheel ?  wheel->value : 0;
-
-        if (absolute_x && absolute_y) {
-                async_exch_t *exch =
-                    async_exchange_begin(mouse_dev->mouse_sess);
-                if (exch != NULL) {
-                        async_msg_4(exch, MOUSEEV_ABS_MOVE_EVENT,
-                            shift_x, shift_y, move_x->logical_maximum, move_y->logical_maximum);
-                        async_exchange_end(exch);
-                }
-
-                // Even if we move the mouse absolutely, we need to resolve wheel
-                shift_x = shift_y = 0;
-        }
-
-
-        if (shift_x || shift_y || shift_z) {
+                usb_log_warning(NAME " No console session.\n");
+                return true;
+        }
+
+        const int shift_x = get_mouse_axis_move_value(hid_dev->report_id,
+            &hid_dev->report, USB_HIDUT_USAGE_GENERIC_DESKTOP_X);
+        const int shift_y = get_mouse_axis_move_value(hid_dev->report_id,
+            &hid_dev->report, USB_HIDUT_USAGE_GENERIC_DESKTOP_Y);
+        const int wheel = get_mouse_axis_move_value(hid_dev->report_id,
+            &hid_dev->report, USB_HIDUT_USAGE_GENERIC_DESKTOP_WHEEL);
+
+        if (shift_x || shift_y || wheel) {
                 async_exch_t *exch =
                     async_exchange_begin(mouse_dev->mouse_sess);
                 if (exch != NULL) {
                         async_msg_3(exch, MOUSEEV_MOVE_EVENT,
-                            shift_x, shift_y, shift_z);
+                            shift_x, shift_y, wheel);
                         async_exchange_end(exch);
                 }
@@ -225 +201 @@
         usb_hid_report_path_t *path = usb_hid_report_path();
         if (path == NULL) {
-                usb_log_warning("Failed to create USB HID report path.");
-                return;
+                usb_log_warning("Failed to create USB HID report path.\n");
+                return true;
         }
         errno_t ret =
@@ -232 +208 @@
         if (ret != EOK) {
                 usb_hid_report_path_free(path);
-                usb_log_warning("Failed to add buttons to report path.");
-                return;
+                usb_log_warning("Failed to add buttons to report path.\n");
+                return true;
         }
         usb_hid_report_path_set_report_id(path, hid_dev->report_id);
@@ -242 +218 @@
 
         while (field != NULL) {
-                usb_log_debug2(NAME " VALUE(%X) USAGE(%X)", field->value,
+                usb_log_debug2(NAME " VALUE(%X) USAGE(%X)\n", field->value,
                     field->usage);
                 assert(field->usage > field->usage_minimum);
@@ -266 +242 @@
 
         usb_hid_report_path_free(path);
+
+        return true;
 }
 
@@ -331 +309 @@
 
         if (mouse_dev->buttons == NULL) {
-                usb_log_error(NAME ": out of memory, giving up on device!");
+                usb_log_error(NAME ": out of memory, giving up on device!\n");
                 free(mouse_dev);
                 return ENOMEM;
@@ -344 +322 @@
 errno_t usb_mouse_init(usb_hid_dev_t *hid_dev, void **data)
 {
-        usb_log_debug("Initializing HID/Mouse structure...");
+        usb_log_debug("Initializing HID/Mouse structure...\n");
 
         if (hid_dev == NULL) {
@@ -353 +331 @@
 
         /* Create the exposed function. */
-        usb_log_debug("Creating DDF function %s...", HID_MOUSE_FUN_NAME);
+        usb_log_debug("Creating DDF function %s...\n", HID_MOUSE_FUN_NAME);
         ddf_fun_t *fun = usb_device_ddf_fun_create(hid_dev->usb_dev,
             fun_exposed, HID_MOUSE_FUN_NAME);
         if (fun == NULL) {
-                usb_log_error("Could not create DDF function node `%s'.",
+                usb_log_error("Could not create DDF function node `%s'.\n",
                     HID_MOUSE_FUN_NAME);
                 return ENOMEM;
@@ -364 +342 @@
         usb_mouse_t *mouse_dev = ddf_fun_data_alloc(fun, sizeof(usb_mouse_t));
         if (mouse_dev == NULL) {
-                usb_log_error("Failed to alloc HID mouse device structure.");
+                usb_log_error("Failed to alloc HID mouse device structure.\n");
                 ddf_fun_destroy(fun);
                 return ENOMEM;
@@ -371 +349 @@
         errno_t ret = mouse_dev_init(mouse_dev, hid_dev);
         if (ret != EOK) {
-                usb_log_error("Failed to init HID mouse device structure.");
+                usb_log_error("Failed to init HID mouse device structure.\n");
                 return ret;
         }
@@ -379 +357 @@
         ret = ddf_fun_bind(fun);
         if (ret != EOK) {
-                usb_log_error("Could not bind DDF function `%s': %s.",
+                usb_log_error("Could not bind DDF function `%s': %s.\n",
                     ddf_fun_get_name(fun), str_error(ret));
                 ddf_fun_destroy(fun);
@@ -385 +363 @@
         }
 
-        usb_log_debug("Adding DDF function `%s' to category %s...",
+        usb_log_debug("Adding DDF function `%s' to category %s...\n",
             ddf_fun_get_name(fun), HID_MOUSE_CATEGORY);
         ret = ddf_fun_add_to_category(fun, HID_MOUSE_CATEGORY);
@@ -412 +390 @@
 
         usb_mouse_t *mouse_dev = data;
-        usb_mouse_process_report(hid_dev, mouse_dev);
-
-        /* Continue polling until the device is about to be removed. */
-        return true;
+
+        return usb_mouse_process_report(hid_dev, mouse_dev);
 }
 
@@ -444 +420 @@
 
         if (rc != EOK) {
-                usb_log_error("Failed to parse boot report descriptor: %s",
+                usb_log_error("Failed to parse boot report descriptor: %s\n",
                     str_error(rc));
                 return rc;