Changeset b7fd2a0 in mainline for uspace/lib/c/generic/io/io.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/io/io.c (modified) (8 diffs)

uspace/lib/c/generic/io/io.c

@@ -297 +297 @@
                 flags |= WALK_MAY_CREATE;
         int file;
-        int rc = vfs_lookup(path, flags, &file);
+        errno_t rc = vfs_lookup(path, flags, &file);
         if (rc != EOK) {
                 errno = rc;
@@ -364 +364 @@
 static int _fclose_nofree(FILE *stream)
 {
-        int rc = 0;
+        errno_t rc = 0;
         
         fflush(stream);
@@ -433 +433 @@
 static size_t _fread(void *buf, size_t size, size_t nmemb, FILE *stream)
 {
-        int rc;
+        errno_t rc;
         size_t nread;
 
@@ -462 +462 @@
 static size_t _fwrite(const void *buf, size_t size, size_t nmemb, FILE *stream)
 {
-        int rc;
+        errno_t rc;
         size_t nwritten;
 
@@ -495 +495 @@
 static void _ffillbuf(FILE *stream)
 {
-        int rc;
+        errno_t rc;
         size_t nread;
 
@@ -801 +801 @@
 int fseek(FILE *stream, long offset, int whence)
 {
-        int rc;
+        errno_t rc;
 
         if (stream->error)
@@ -877 +877 @@
         
         if ((stream->fd >= 0) && (stream->need_sync)) {
-                int rc;
+                errno_t rc;
 
                 /**
@@ -934 +934 @@
 }
 
-int vfs_fhandle(FILE *stream, int *handle)
+errno_t vfs_fhandle(FILE *stream, int *handle)
 {
         if (stream->fd >= 0) {