Changeset b7fd2a0 in mainline for uspace/lib/drv/generic/remote_hw_res.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/drv/generic/remote_hw_res.c (modified) (5 diffs)

uspace/lib/drv/generic/remote_hw_res.c

@@ -79 +79 @@
         
         const int irq = DEV_IPC_GET_ARG1(*call);
-        const int ret = hw_res_ops->enable_interrupt(fun, irq);
+        const errno_t ret = hw_res_ops->enable_interrupt(fun, irq);
         async_answer_0(callid, ret);
 }
@@ -94 +94 @@
         
         const int irq = DEV_IPC_GET_ARG1(*call);
-        const int ret = hw_res_ops->disable_interrupt(fun, irq);
+        const errno_t ret = hw_res_ops->disable_interrupt(fun, irq);
         async_answer_0(callid, ret);
 }
@@ -109 +109 @@
         
         const int irq = DEV_IPC_GET_ARG1(*call);
-        const int ret = hw_res_ops->enable_interrupt(fun, irq);
+        const errno_t ret = hw_res_ops->enable_interrupt(fun, irq);
         async_answer_0(callid, ret);
 }
@@ -153 +153 @@
         const uint32_t size = DEV_IPC_GET_ARG3(*call);
 
-        const int ret = hw_res_ops->dma_channel_setup(
+        const errno_t ret = hw_res_ops->dma_channel_setup(
             fun, channel, address, size, mode);
         async_answer_0(callid, ret);
@@ -169 +169 @@
         const unsigned channel = DEV_IPC_GET_ARG1(*call);
         size_t remain = 0;
-        const int ret = hw_res_ops->dma_channel_remain(fun, channel, &remain);
+        const errno_t ret = hw_res_ops->dma_channel_remain(fun, channel, &remain);
         async_answer_1(callid, ret, remain);
 }