Changeset b7fd2a0 in mainline for uspace/lib/drv/generic/remote_ieee80211.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/drv/generic/remote_ieee80211.c (modified) (12 diffs)

uspace/lib/drv/generic/remote_ieee80211.c

@@ -62 +62 @@
  *
  */
-int ieee80211_get_scan_results(async_sess_t *dev_sess,
+errno_t ieee80211_get_scan_results(async_sess_t *dev_sess,
     ieee80211_scan_results_t *results, bool now)
 {
@@ -71 +71 @@
         aid_t aid = async_send_2(exch, DEV_IFACE_ID(IEEE80211_DEV_IFACE),
             IEEE80211_GET_SCAN_RESULTS, now, NULL);
-        int rc = async_data_read_start(exch, results,
+        errno_t rc = async_data_read_start(exch, results,
             sizeof(ieee80211_scan_results_t));
         async_exchange_end(exch);
         
-        int res;
+        errno_t res;
         async_wait_for(aid, &res);
         
         if(res != EOK)
-                return (int) res;
+                return (errno_t) res;
         
         return rc;
@@ -100 +100 @@
         size_t count;
         
-        int rc = inetcfg_get_link_list(&link_list, &count);
+        errno_t rc = inetcfg_get_link_list(&link_list, &count);
         if (rc != EOK)
                 return -1;
@@ -126 +126 @@
  *
  */
-int ieee80211_connect(async_sess_t *dev_sess, char *ssid_start, char *password)
+errno_t ieee80211_connect(async_sess_t *dev_sess, char *ssid_start, char *password)
 {
         assert(ssid_start);
         
-        int rc_orig;
+        errno_t rc_orig;
         
         async_exch_t *exch = async_exchange_begin(dev_sess);
@@ -137 +137 @@
             IEEE80211_CONNECT, NULL);
         
-        int rc = async_data_write_start(exch, ssid_start,
+        errno_t rc = async_data_write_start(exch, ssid_start,
             str_size(ssid_start) + 1);
         if (rc != EOK) {
@@ -144 +144 @@
                 
                 if (rc_orig == EOK)
-                        return (int) rc;
-                
-                return (int) rc_orig;
+                        return (errno_t) rc;
+                
+                return (errno_t) rc_orig;
         }
         
@@ -159 +159 @@
                 
                 if (rc_orig == EOK)
-                        return (int) rc;
-                
-                return (int) rc_orig;
+                        return (errno_t) rc;
+                
+                return (errno_t) rc_orig;
         }
         
@@ -182 +182 @@
         rc = dhcp_discover(link_id);
         
-        return (int) rc;
+        return (errno_t) rc;
 }
 
@@ -193 +193 @@
  *
  */
-int ieee80211_disconnect(async_sess_t *dev_sess)
+errno_t ieee80211_disconnect(async_sess_t *dev_sess)
 {
         async_exch_t *exch = async_exchange_begin(dev_sess);
-        int rc = async_req_1_0(exch, DEV_IFACE_ID(IEEE80211_DEV_IFACE),
+        errno_t rc = async_req_1_0(exch, DEV_IFACE_ID(IEEE80211_DEV_IFACE),
             IEEE80211_DISCONNECT);
         async_exchange_end(exch);
@@ -278 +278 @@
         bool now = IPC_GET_ARG2(*call);
         
-        int rc = ieee80211_iface->get_scan_results(fun, &scan_results, now);
+        errno_t rc = ieee80211_iface->get_scan_results(fun, &scan_results, now);
         if (rc == EOK) {
                 ipc_callid_t data_callid;
@@ -324 +324 @@
         }
         
-        int rc = async_data_write_finalize(data_callid, ssid_start, len);
+        errno_t rc = async_data_write_finalize(data_callid, ssid_start, len);
         if (rc != EOK) {
                 async_answer_0(data_callid, EINVAL);
@@ -360 +360 @@
         ieee80211_iface_t *ieee80211_iface = (ieee80211_iface_t *) iface;
         assert(ieee80211_iface->disconnect);
-        int rc = ieee80211_iface->disconnect(fun);
+        errno_t rc = ieee80211_iface->disconnect(fun);
         async_answer_0(callid, rc);
 }