Changeset b7fd2a0 in mainline for uspace/lib/drv/include/usb_iface.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/drv/include/usb_iface.h (modified) (1 diff)

uspace/lib/drv/include/usb_iface.h

@@ -95 +95 @@
 extern void usb_dev_disconnect(usb_dev_session_t *);
 
-extern int usb_get_my_interface(async_exch_t *, int *);
-extern int usb_get_my_device_handle(async_exch_t *, devman_handle_t *);
+extern errno_t usb_get_my_interface(async_exch_t *, int *);
+extern errno_t usb_get_my_device_handle(async_exch_t *, devman_handle_t *);
 
-extern int usb_reserve_default_address(async_exch_t *, usb_speed_t);
-extern int usb_release_default_address(async_exch_t *);
+extern errno_t usb_reserve_default_address(async_exch_t *, usb_speed_t);
+extern errno_t usb_release_default_address(async_exch_t *);
 
-extern int usb_device_enumerate(async_exch_t *, unsigned port);
-extern int usb_device_remove(async_exch_t *, unsigned port);
+extern errno_t usb_device_enumerate(async_exch_t *, unsigned port);
+extern errno_t usb_device_remove(async_exch_t *, unsigned port);
 
-extern int usb_register_endpoint(async_exch_t *, usb_endpoint_t,
+extern errno_t usb_register_endpoint(async_exch_t *, usb_endpoint_t,
     usb_transfer_type_t, usb_direction_t, size_t, unsigned, unsigned);
-extern int usb_unregister_endpoint(async_exch_t *, usb_endpoint_t,
+extern errno_t usb_unregister_endpoint(async_exch_t *, usb_endpoint_t,
     usb_direction_t);
-extern int usb_read(async_exch_t *, usb_endpoint_t, uint64_t, void *, size_t,
+extern errno_t usb_read(async_exch_t *, usb_endpoint_t, uint64_t, void *, size_t,
     size_t *);
-extern int usb_write(async_exch_t *, usb_endpoint_t, uint64_t, const void *,
+extern errno_t usb_write(async_exch_t *, usb_endpoint_t, uint64_t, const void *,
     size_t);
 
 /** Callback for outgoing transfer. */
-typedef void (*usb_iface_transfer_out_callback_t)(int, void *);
+typedef void (*usb_iface_transfer_out_callback_t)(errno_t, void *);
 
 /** Callback for incoming transfer. */
-typedef void (*usb_iface_transfer_in_callback_t)(int, size_t, void *);
+typedef void (*usb_iface_transfer_in_callback_t)(errno_t, size_t, void *);
 
 /** USB device communication interface. */
 typedef struct {
-        int (*get_my_interface)(ddf_fun_t *, int *);
-        int (*get_my_device_handle)(ddf_fun_t *, devman_handle_t *);
+        errno_t (*get_my_interface)(ddf_fun_t *, int *);
+        errno_t (*get_my_device_handle)(ddf_fun_t *, devman_handle_t *);
 
-        int (*reserve_default_address)(ddf_fun_t *, usb_speed_t);
-        int (*release_default_address)(ddf_fun_t *);
+        errno_t (*reserve_default_address)(ddf_fun_t *, usb_speed_t);
+        errno_t (*release_default_address)(ddf_fun_t *);
 
-        int (*device_enumerate)(ddf_fun_t *, unsigned);
-        int (*device_remove)(ddf_fun_t *, unsigned);
+        errno_t (*device_enumerate)(ddf_fun_t *, unsigned);
+        errno_t (*device_remove)(ddf_fun_t *, unsigned);
 
-        int (*register_endpoint)(ddf_fun_t *, usb_endpoint_t,
+        errno_t (*register_endpoint)(ddf_fun_t *, usb_endpoint_t,
             usb_transfer_type_t, usb_direction_t, size_t, unsigned, unsigned);
-        int (*unregister_endpoint)(ddf_fun_t *, usb_endpoint_t,
+        errno_t (*unregister_endpoint)(ddf_fun_t *, usb_endpoint_t,
             usb_direction_t);
 
-        int (*read)(ddf_fun_t *, usb_endpoint_t, uint64_t, uint8_t *, size_t,
+        errno_t (*read)(ddf_fun_t *, usb_endpoint_t, uint64_t, uint8_t *, size_t,
             usb_iface_transfer_in_callback_t, void *);
-        int (*write)(ddf_fun_t *, usb_endpoint_t, uint64_t, const uint8_t *,
+        errno_t (*write)(ddf_fun_t *, usb_endpoint_t, uint64_t, const uint8_t *,
             size_t, usb_iface_transfer_out_callback_t, void *);
 } usb_iface_t;