Changeset b7fd2a0 in mainline for uspace/lib/nic/include/nic_impl.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/nic/include/nic_impl.h (modified) (1 diff)

uspace/lib/nic/include/nic_impl.h

@@ -46 +46 @@
  * inject some adaptation layer between the DDF call and NICF implementation */
 
-extern int nic_get_address_impl(ddf_fun_t *dev_fun, nic_address_t *address);
-extern int nic_send_frame_impl(ddf_fun_t *dev_fun, void *data, size_t size);
-extern int nic_callback_create_impl(ddf_fun_t *dev_fun);
-extern int nic_get_state_impl(ddf_fun_t *dev_fun, nic_device_state_t *state);
-extern int nic_set_state_impl(ddf_fun_t *dev_fun, nic_device_state_t state);
-extern int nic_get_stats_impl(ddf_fun_t *dev_fun, nic_device_stats_t *stats);
-extern int nic_unicast_get_mode_impl(ddf_fun_t *dev_fun,
+extern errno_t nic_get_address_impl(ddf_fun_t *dev_fun, nic_address_t *address);
+extern errno_t nic_send_frame_impl(ddf_fun_t *dev_fun, void *data, size_t size);
+extern errno_t nic_callback_create_impl(ddf_fun_t *dev_fun);
+extern errno_t nic_get_state_impl(ddf_fun_t *dev_fun, nic_device_state_t *state);
+extern errno_t nic_set_state_impl(ddf_fun_t *dev_fun, nic_device_state_t state);
+extern errno_t nic_get_stats_impl(ddf_fun_t *dev_fun, nic_device_stats_t *stats);
+extern errno_t nic_unicast_get_mode_impl(ddf_fun_t *dev_fun,
     nic_unicast_mode_t *, size_t, nic_address_t *, size_t *);
-extern int nic_unicast_set_mode_impl(ddf_fun_t *dev_fun,
+extern errno_t nic_unicast_set_mode_impl(ddf_fun_t *dev_fun,
     nic_unicast_mode_t, const nic_address_t *, size_t);
-extern int nic_multicast_get_mode_impl(ddf_fun_t *dev_fun,
+extern errno_t nic_multicast_get_mode_impl(ddf_fun_t *dev_fun,
     nic_multicast_mode_t *, size_t, nic_address_t *, size_t *);
-extern int nic_multicast_set_mode_impl(ddf_fun_t *dev_fun,
+extern errno_t nic_multicast_set_mode_impl(ddf_fun_t *dev_fun,
     nic_multicast_mode_t, const nic_address_t *, size_t);
-extern int nic_broadcast_get_mode_impl(ddf_fun_t *, nic_broadcast_mode_t *);
-extern int nic_broadcast_set_mode_impl(ddf_fun_t *, nic_broadcast_mode_t);
-extern int nic_blocked_sources_get_impl(ddf_fun_t *,
+extern errno_t nic_broadcast_get_mode_impl(ddf_fun_t *, nic_broadcast_mode_t *);
+extern errno_t nic_broadcast_set_mode_impl(ddf_fun_t *, nic_broadcast_mode_t);
+extern errno_t nic_blocked_sources_get_impl(ddf_fun_t *,
     size_t, nic_address_t *, size_t *);
-extern int nic_blocked_sources_set_impl(ddf_fun_t *, const nic_address_t *, size_t);
-extern int nic_vlan_get_mask_impl(ddf_fun_t *, nic_vlan_mask_t *);
-extern int nic_vlan_set_mask_impl(ddf_fun_t *, const nic_vlan_mask_t *);
-extern int nic_wol_virtue_add_impl(ddf_fun_t *dev_fun, nic_wv_type_t type,
+extern errno_t nic_blocked_sources_set_impl(ddf_fun_t *, const nic_address_t *, size_t);
+extern errno_t nic_vlan_get_mask_impl(ddf_fun_t *, nic_vlan_mask_t *);
+extern errno_t nic_vlan_set_mask_impl(ddf_fun_t *, const nic_vlan_mask_t *);
+extern errno_t nic_wol_virtue_add_impl(ddf_fun_t *dev_fun, nic_wv_type_t type,
     const void *data, size_t length, nic_wv_id_t *new_id);
-extern int nic_wol_virtue_remove_impl(ddf_fun_t *dev_fun, nic_wv_id_t id);
-extern int nic_wol_virtue_probe_impl(ddf_fun_t *dev_fun, nic_wv_id_t id,
+extern errno_t nic_wol_virtue_remove_impl(ddf_fun_t *dev_fun, nic_wv_id_t id);
+extern errno_t nic_wol_virtue_probe_impl(ddf_fun_t *dev_fun, nic_wv_id_t id,
     nic_wv_type_t *type, size_t max_length, void *data, size_t *length);
-extern int nic_wol_virtue_list_impl(ddf_fun_t *dev_fun, nic_wv_type_t type,
+extern errno_t nic_wol_virtue_list_impl(ddf_fun_t *dev_fun, nic_wv_type_t type,
     size_t max_count, nic_wv_id_t *id_list, size_t *id_count);
-extern int nic_wol_virtue_get_caps_impl(ddf_fun_t *, nic_wv_type_t, int *);
-extern int nic_poll_get_mode_impl(ddf_fun_t *,
+extern errno_t nic_wol_virtue_get_caps_impl(ddf_fun_t *, nic_wv_type_t, int *);
+extern errno_t nic_poll_get_mode_impl(ddf_fun_t *,
     nic_poll_mode_t *, struct timeval *);
-extern int nic_poll_set_mode_impl(ddf_fun_t *,
+extern errno_t nic_poll_set_mode_impl(ddf_fun_t *,
     nic_poll_mode_t, const struct timeval *);
-extern int nic_poll_now_impl(ddf_fun_t *);
+extern errno_t nic_poll_now_impl(ddf_fun_t *);
 
 extern void nic_default_handler_impl(ddf_fun_t *dev_fun,
         ipc_callid_t callid, ipc_call_t *call);
-extern int nic_open_impl(ddf_fun_t *fun);
+extern errno_t nic_open_impl(ddf_fun_t *fun);
 extern void nic_close_impl(ddf_fun_t *fun);