Changeset b7fd2a0 in mainline for uspace/lib/trackmod/xm.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/trackmod/xm.c (modified) (8 diffs)

uspace/lib/trackmod/xm.c

@@ -53 +53 @@
  * @return EOK on success, EIO on format error, ENOMEM if out of memory.
  */
-static int trackmod_xm_load_order_list(xm_hdr_t *xm_hdr, trackmod_module_t *module)
+static errno_t trackmod_xm_load_order_list(xm_hdr_t *xm_hdr, trackmod_module_t *module)
 {
-        int rc;
+        errno_t rc;
         size_t i;
 
@@ -94 +94 @@
  * @return        EOK on success, EINVAL if there is error in the coded data.
  */
-static int trackmod_xm_decode_pattern(uint8_t *data, size_t dsize,
+static errno_t trackmod_xm_decode_pattern(uint8_t *data, size_t dsize,
     trackmod_pattern_t *pattern)
 {
@@ -162 +162 @@
  * @return EOK on success, EIO on format error, ENOMEM if out of memory.
  */
-static int trackmod_xm_load_patterns(FILE *f, trackmod_module_t *module)
+static errno_t trackmod_xm_load_patterns(FILE *f, trackmod_module_t *module)
 {
         size_t i;
@@ -173 +173 @@
         uint8_t *buf = NULL;
         long seek_amount;
-        int rc;
+        errno_t rc;
         int ret;
 
@@ -281 +281 @@
  * @return EOK on success, EIO on format error, ENOMEM if out of memory.
  */
-static int trackmod_xm_load_instruments(xm_hdr_t *xm_hdr, FILE *f,
+static errno_t trackmod_xm_load_instruments(xm_hdr_t *xm_hdr, FILE *f,
     trackmod_module_t *module)
 {
@@ -297 +297 @@
         void *smp_data;
         long pos;
-        int rc;
+        errno_t rc;
         int ret;
 
@@ -422 +422 @@
  *                or if any error is found in the format of the file.
  */
-int trackmod_xm_load(char *fname, trackmod_module_t **rmodule)
+errno_t trackmod_xm_load(char *fname, trackmod_module_t **rmodule)
 {
         FILE *f = NULL;
@@ -429 +429 @@
         size_t nread;
         size_t hdr_size;
-        int rc;
+        errno_t rc;
 
         f = fopen(fname, "rb");