Changeset b7fd2a0 in mainline for uspace/lib/usbdev/include/usb/dev/poll.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/usbdev/include/usb/dev/poll.h (modified) (2 diffs)

uspace/lib/usbdev/include/usb/dev/poll.h

@@ -87 +87 @@
          * @return Whether to continue in polling.
          */
-        bool (*on_error)(usb_device_t *dev, int err_code, void *arg);
+        bool (*on_error)(usb_device_t *dev, errno_t err_code, void *arg);
         /** Argument to pass to callbacks. */
         void *arg;
@@ -95 +95 @@
 typedef void (*usb_polling_terminted_callback_t)(usb_device_t *, bool, void *);
 
-extern int usb_device_auto_polling(usb_device_t *, usb_endpoint_t,
+extern errno_t usb_device_auto_polling(usb_device_t *, usb_endpoint_t,
     const usb_device_auto_polling_t *, size_t);
 
-extern int usb_device_auto_poll(usb_device_t *, usb_endpoint_t,
+extern errno_t usb_device_auto_poll(usb_device_t *, usb_endpoint_t,
     usb_polling_callback_t, size_t, int, usb_polling_terminted_callback_t, void *);
 
-extern int usb_device_auto_polling_desc(usb_device_t *,
+extern errno_t usb_device_auto_polling_desc(usb_device_t *,
     const usb_endpoint_description_t *, const usb_device_auto_polling_t *,
     size_t);
 
-extern int usb_device_auto_poll_desc(usb_device_t *,
+extern errno_t usb_device_auto_poll_desc(usb_device_t *,
     const usb_endpoint_description_t *, usb_polling_callback_t, size_t, int,
     usb_polling_terminted_callback_t, void *);