Changes in uspace/lib/usbdev/src/devdrv.c [e0a5d4c:b7fd2a0] in mainline

File:

• uspace/lib/usbdev/src/devdrv.c (modified) (20 diffs)

uspace/lib/usbdev/src/devdrv.c

@@ -2 +2 @@
  * Copyright (c) 2011 Vojtech Horky
  * Copyright (c) 2011 Jan Vesely
- * Copyright (c) 2018 Ondrej Hlavaty, Petr Manek, Michal Staruch
  * All rights reserved.
  *
@@ -49 +48 @@
 #include <devman.h>
 #include <errno.h>
-#include <str_error.h>
 #include <stdlib.h>
 
@@ -58 +56 @@
         /** Connection to device on USB bus */
         usb_dev_session_t *bus_session;
-
+        
         /** devman handle */
         devman_handle_t handle;
-
+        
         /** The default control pipe. */
         usb_pipe_t ctrl_pipe;
-
+        
         /** Other endpoint pipes.
          *
@@ -71 +69 @@
          */
         usb_endpoint_mapping_t *pipes;
-
+        
         /** Number of other endpoint pipes. */
         size_t pipes_count;
-
-        /** USB address of this device */
-        usb_address_t address;
-
-        /** Depth in the USB hub hiearchy */
-        unsigned depth;
-
-        /** USB speed of this device */
-        usb_speed_t speed;
-
+        
         /** Current interface.
          *
@@ -90 +79 @@
          */
         int interface_no;
-
+        
         /** Alternative interfaces. */
         usb_alternate_interfaces_t alternate_interfaces;
-
+        
         /** Some useful descriptors for USB device. */
         usb_device_descriptors_t descriptors;
-
+        
         /** Generic DDF device backing this one. DO NOT TOUCH! */
         ddf_dev_t *ddf_dev;
-
+        
         /** Custom driver data.
          *
@@ -157 +146 @@
                 return rc;
         }
-
+        
         /* Change current alternative */
         usb_dev->alternate_interfaces.current = alternate_setting;
@@ -266 +255 @@
 
         /* Register created pipes. */
-        unsigned pipes_registered = 0;
         for (size_t i = 0; i < pipe_count; i++) {
                 if (pipes[i].present) {
-                        rc = usb_pipe_register(&pipes[i].pipe, pipes[i].descriptor, pipes[i].companion_descriptor);
+                        rc = usb_pipe_register(&pipes[i].pipe,
+                            pipes[i].descriptor->poll_interval);
                         if (rc != EOK) {
                                 goto rollback_unregister_endpoints;
                         }
                 }
-                pipes_registered++;
         }
 
@@ -289 +277 @@
          */
 rollback_unregister_endpoints:
-        for (size_t i = 0; i < pipes_registered; i++) {
+        for (size_t i = 0; i < pipe_count; i++) {
                 if (pipes[i].present) {
                         usb_pipe_unregister(&pipes[i].pipe);
@@ -308 +296 @@
         assert(usb_dev);
         assert(usb_dev->pipes || usb_dev->pipes_count == 0);
-
+        
         /* Destroy the pipes. */
-        int rc;
         for (size_t i = 0; i < usb_dev->pipes_count; ++i) {
-                usb_log_debug2("Unregistering pipe %zu: %spresent.",
+                usb_log_debug2("Unregistering pipe %zu: %spresent.\n",
                     i, usb_dev->pipes[i].present ? "" : "not ");
-
-                rc = usb_device_unmap_ep(usb_dev->pipes + i);
-                if (rc != EOK && rc != ENOENT)
-                        usb_log_warning("Unregistering pipe %zu failed: %s", i, str_error(rc));
-        }
-
+                if (usb_dev->pipes[i].present)
+                        usb_pipe_unregister(&usb_dev->pipes[i].pipe);
+        }
+        
         free(usb_dev->pipes);
         usb_dev->pipes = NULL;
@@ -342 +327 @@
 }
 
-int usb_device_unmap_ep(usb_endpoint_mapping_t *epm)
-{
-        assert(epm);
-
-        if (!epm->present)
-                return ENOENT;
-
-        const int rc = usb_pipe_unregister(&epm->pipe);
-        if (rc != EOK)
-                return rc;
-
-        epm->present = false;
-        return EOK;
-}
-
-usb_address_t usb_device_get_address(const usb_device_t *usb_dev)
-{
-        assert(usb_dev);
-        return usb_dev->depth;
-}
-
-unsigned usb_device_get_depth(const usb_device_t *usb_dev)
-{
-        assert(usb_dev);
-        return usb_dev->depth;
-}
-
-usb_speed_t usb_device_get_speed(const usb_device_t *usb_dev)
-{
-        assert(usb_dev);
-        return usb_dev->speed;
-}
-
-int usb_device_get_iface_number(const usb_device_t *usb_dev)
+usb_endpoint_mapping_t * usb_device_get_mapped_ep(
+    usb_device_t *usb_dev, usb_endpoint_t ep)
+{
+        assert(usb_dev);
+        for (unsigned i = 0; i < usb_dev->pipes_count; ++i) {
+                if (usb_dev->pipes[i].pipe.endpoint_no == ep)
+                        return &usb_dev->pipes[i];
+        }
+        return NULL;
+}
+
+int usb_device_get_iface_number(usb_device_t *usb_dev)
 {
         assert(usb_dev);
@@ -381 +344 @@
 }
 
-devman_handle_t usb_device_get_devman_handle(const usb_device_t *usb_dev)
+devman_handle_t usb_device_get_devman_handle(usb_device_t *usb_dev)
 {
         assert(usb_dev);
@@ -431 +394 @@
  */
 static errno_t usb_device_init(usb_device_t *usb_dev, ddf_dev_t *ddf_dev,
-    const usb_endpoint_description_t **endpoints, const char **errstr_ptr)
+    const usb_endpoint_description_t **endpoints, const char **errstr_ptr,
+    devman_handle_t handle, int interface_no)
 {
         assert(usb_dev != NULL);
@@ -439 +403 @@
 
         usb_dev->ddf_dev = ddf_dev;
+        usb_dev->handle = handle;
+        usb_dev->interface_no = interface_no;
         usb_dev->driver_data = NULL;
         usb_dev->descriptors.full_config = NULL;
@@ -445 +411 @@
         usb_dev->pipes = NULL;
 
-        usb_dev->bus_session = usb_dev_connect(usb_dev->handle);
+        usb_dev->bus_session = usb_dev_connect(handle);
 
         if (!usb_dev->bus_session) {
@@ -454 +420 @@
         /* This pipe was registered by the hub driver,
          * during device initialization. */
-        errno_t rc = usb_pipe_initialize_default_control(&usb_dev->ctrl_pipe, usb_dev->bus_session);
+        errno_t rc = usb_pipe_initialize_default_control(
+            &usb_dev->ctrl_pipe, usb_dev->bus_session);
         if (rc != EOK) {
                 usb_dev_disconnect(usb_dev->bus_session);
@@ -473 +440 @@
          * it makes no sense to speak about alternate interfaces when
          * controlling a device. */
-        usb_alternate_interfaces_init(&usb_dev->alternate_interfaces,
+        rc = usb_alternate_interfaces_init(&usb_dev->alternate_interfaces,
             usb_dev->descriptors.full_config,
             usb_dev->descriptors.full_config_size, usb_dev->interface_no);
@@ -490 +457 @@
 }
 
-static errno_t usb_device_get_info(async_sess_t *sess, usb_device_t *dev)
-{
-        assert(dev);
-
+static errno_t usb_device_get_info(async_sess_t *sess, devman_handle_t *handle,
+        int *iface_no)
+{
+        assert(handle);
+        assert(iface_no);
+        
         async_exch_t *exch = async_exchange_begin(sess);
         if (!exch)
                 return EPARTY;
-
-        usb_device_desc_t dev_desc;
-        const errno_t ret = usb_get_my_description(exch, &dev_desc);
-
+        
+        errno_t ret = usb_get_my_device_handle(exch, handle);
         if (ret == EOK) {
-                dev->address = dev_desc.address;
-                dev->depth = dev_desc.depth;
-                dev->speed = dev_desc.speed;
-                dev->handle = dev_desc.handle;
-                dev->interface_no = dev_desc.iface;
-        }
-
+                ret = usb_get_my_interface(exch, iface_no);
+                if (ret == ENOTSUP) {
+                        *iface_no = -1;
+                        ret = EOK;
+                }
+        }
+        
         async_exchange_end(exch);
         return ret;
@@ -518 +485 @@
         assert(ddf_dev);
         assert(err);
+
+        devman_handle_t h = 0;
+        int iface_no = -1;
 
         async_sess_t *sess = ddf_dev_parent_sess_get(ddf_dev);
         if (sess == NULL)
                 return ENOMEM;
+        const errno_t ret = usb_device_get_info(sess, &h, &iface_no);
+        if (ret != EOK)
+                return ret;
 
         usb_device_t *usb_dev =
@@ -529 +502 @@
                 return ENOMEM;
         }
-
-        const errno_t ret = usb_device_get_info(sess, usb_dev);
-        if (ret != EOK)
-                return ret;
-
-        return usb_device_init(usb_dev, ddf_dev, desc, err);
+        
+        return usb_device_init(usb_dev, ddf_dev, desc, err, h, iface_no);
 }
 
@@ -548 +517 @@
 usb_device_t * usb_device_create(devman_handle_t handle)
 {
+        devman_handle_t h = 0;
+        int iface_no = -1;
+
+        async_sess_t *sess = devman_device_connect(handle, IPC_FLAG_BLOCKING);
+        errno_t ret = usb_device_get_info(sess, &h, &iface_no);
+        if (sess)
+                async_hangup(sess);
+        if (ret != EOK)
+                return NULL;
+
         usb_device_t *usb_dev = malloc(sizeof(usb_device_t));
         if (!usb_dev)
                 return NULL;
 
-        async_sess_t *sess = devman_device_connect(handle, IPC_FLAG_BLOCKING);
-        errno_t ret = usb_device_get_info(sess, usb_dev);
-        if (sess)
-                async_hangup(sess);
-        if (ret != EOK) {
-                free(usb_dev);
-                return NULL;
-        }
-
         const char* dummy = NULL;
-        ret = usb_device_init(usb_dev, NULL, NULL, &dummy);
+        ret = usb_device_init(usb_dev, NULL, NULL, &dummy, handle, iface_no);
         if (ret != EOK) {
                 free(usb_dev);