Changeset b7fd2a0 in mainline for uspace/lib/usbdev/src/devpoll.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/usbdev/src/devpoll.c (modified) (7 diffs)

uspace/lib/usbdev/src/devpoll.c

@@ -77 +77 @@
  * @return Always EOK.
  */
-static int polling_fibril(void *arg)
+static errno_t polling_fibril(void *arg)
 {
         assert(arg);
@@ -102 +102 @@
         while (failed_attempts <= params->max_failures) {
                 size_t actual_size;
-                const int rc = usb_pipe_read(pipe, data->buffer,
+                const errno_t rc = usb_pipe_read(pipe, data->buffer,
                     data->request_size, &actual_size);
 
@@ -206 +206 @@
  * @retval EOK New fibril polling the device was already started.
  */
-static int usb_device_auto_polling_internal(usb_device_t *dev,
+static errno_t usb_device_auto_polling_internal(usb_device_t *dev,
     usb_endpoint_mapping_t *epm, const usb_device_auto_polling_t *polling,
     size_t request_size)
@@ -275 +275 @@
  * @retval EOK New fibril polling the device was already started.
  */
-int usb_device_auto_polling(usb_device_t *usb_dev, usb_endpoint_t ep,
+errno_t usb_device_auto_polling(usb_device_t *usb_dev, usb_endpoint_t ep,
     const usb_device_auto_polling_t *polling, size_t req_size)
 {
@@ -301 +301 @@
  * @retval EOK New fibril polling the device was already started.
  */
-int usb_device_auto_poll(usb_device_t *dev, usb_endpoint_t ep,
+errno_t usb_device_auto_poll(usb_device_t *dev, usb_endpoint_t ep,
     usb_polling_callback_t callback, size_t request_size, int delay,
     usb_polling_terminted_callback_t terminated_callback, void *arg)
@@ -321 +321 @@
 }
 
-int usb_device_auto_polling_desc(usb_device_t *usb_dev,
+errno_t usb_device_auto_polling_desc(usb_device_t *usb_dev,
     const usb_endpoint_description_t *desc,
     const usb_device_auto_polling_t *polling, size_t req_size)
@@ -330 +330 @@
 }
 
-int usb_device_auto_poll_desc(usb_device_t * usb_dev,
+errno_t usb_device_auto_poll_desc(usb_device_t * usb_dev,
     const usb_endpoint_description_t *desc, usb_polling_callback_t callback,
     size_t req_size, int delay,